~azzar1/unity/add-show-desktop-key

  • Committer: wagrant
  • Date: 2008-12-20 03:46:56 UTC
  • Revision ID: svn-v3-trunk0:2b9c9e99-6f39-0410-b283-7f802c844ae2:trunk:1060
Make IVLE work fine in Firefox 3.1 (ie. Gecko/XULRunner 1.9.1). Gecko 1.9.1 has
a built-in JSON object, so our json2.js isn't used, and compatibility problems
arise. The only one significant to us is that Gecko's doesn't support having
a primitive as the root object. Unfortunately we use that sort of thing in a
few places, so IVLE ends up pretty much broken.

A few adjustments were needed both client- and server-side for proto changes:

 - consoleservice and the JS interacting with it now deal with the key returned
   by start_server in a dict like {'key': ...}.
 - tutorialservice and interacting JS deal with code returned by getattempt in
   a dict like {'code': ...}.


The JS repr() implementation used JSON.stringify on the given object, and was
used only with primitive objects in order to create function calls. This needed
to be eliminated for compatibility with the new Gecko, so these call
constructions were replaced with better events:

 - listing.js constructed events for generated file listings by repr()ing some
   strings. That is foul, so we instead use DOM operations from 'this' in a
   somewhat nicer event handler.
 - tutorial.js previously created save_exercise() call strings by repr()ing
   lots of stuff. That was really bad, and broke like the rest. I replaced it
   with something that's still bad, but not quite as awful - grabbing the call
   string from the save button. This should be fixed at some point.
 - console.js had some strange Firebug logging stuff which used repr(). I
   removed it, as it shouldn't have been in released code in the first place.

repr() itself was removed after all references were.
   
Filename Latest Rev Last Changed Committer Comment Size
..
diffservice 879 16 years ago wagrant diffservice, fileservice_lib: Factor out conversio 3.2 KB Diff Download File
fileservice 854 16 years ago wagrant Enable the new CGIRequest error handler in the dif 1.4 KB Diff Download File
interpretservice 993 16 years ago wagrant interpretservice: Don't die horribly if we can't c 3 KB Diff Download File
python-console 1043 16 years ago dcoles Console: Minor fixes. ConsoleService will now also 13 KB Diff Download File
serveservice 851 16 years ago wagrant Give CGIRequest an exception handler which turns a 3.2 KB Diff Download File
svnlogservice 903 16 years ago wagrant svnlogservice: Add the ability to show diff links. 3.5 KB Diff Download File
usrmgt-server 989 16 years ago dcoles Groups: Added userservice/assign_group call. This 4.3 KB Diff Download File