2
# Copyright (C) 2007-2008 The University of Melbourne
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12
# GNU General Public License for more details.
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
16
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
18
# Module: File Service / Action
22
# Handles actions requested by the client as part of the 2-stage process of
23
# fileservice (the second part being the return listing).
27
# The most important argument is "action". This determines which action is
28
# taken. Note that action, and all other arguments, are ignored unless the
29
# request is a POST request. The other arguments depend upon the action.
30
# Note that paths are often specified as arguments. Paths that begin with a
31
# slash are taken relative to the user's home directory (the top-level
32
# directory seen when fileservice has no arguments or path). Paths without a
33
# slash are taken relative to the specified path.
35
# action=remove: Delete a file(s) or directory(s) (recursively).
36
# path: The path to the file or directory to delete. Can be specified
39
# action=move: Move or rename a file or directory.
40
# from: The path to the file or directory to be renamed.
41
# to: The path of the target filename. Error if the file already
44
# action=putfile: Upload a file to the student workspace.
45
# path: The path to the file to be written. Error if the target
46
# file is a directory.
47
# data: Bytes to be written to the file verbatim. May either be
48
# a string variable or a file upload.
49
# overwrite: Optional. If supplied, the file will be overwritten.
50
# Otherwise, error if path already exists.
52
# action=putfiles: Upload multiple files to the student workspace, and
53
# optionally accept zip files which will be unpacked.
54
# path: The path to the DIRECTORY to place files in. Must not be a
56
# data: A file upload (may not be a simple string). The filename
57
# will be used to determine the target filename within
59
# unpack: Optional. If supplied, if any data is a valid ZIP file,
60
# will create a directory instead and unpack the ZIP file
63
# action=mkdir: Create a directory. The parent dir must exist.
64
# path: The path to a file which does not exist, but whose parent
65
# does. The dir will be made with this name.
67
# The differences between putfile and putfiles are:
68
# * putfile can only accept a single file, and can't unpack zipfiles.
69
# * putfile can accept string data, doesn't have to be a file upload.
70
# * putfile ignores the upload filename, the entire filename is specified on
71
# path. putfiles calls files after the name on the user's machine.
73
# action=paste: Copy or move the files to a specified dir.
74
# src: The path to the DIRECTORY to get the files from (relative).
75
# dst: The path to the DIRECTORY to paste the files to. Must not
77
# mode: 'copy' or 'move'
78
# file: File to be copied or moved, relative to src, to a destination
79
# relative to dst. Can be specified multiple times.
82
# action=svnadd: Add an existing file(s) to version control.
83
# path: The path to the file to be added. Can be specified multiple
86
# action=svnrevert: Revert a file(s) to its state as of the current revision
88
# path: The path to the file to be reverted. Can be specified multiple
91
# action=svnupdate: Bring a file up to date with the head revision.
92
# path: The path to the file to be updated. Only one file may be
95
# action=svnpublish: Set the "published" flag on a file to True.
96
# path: The path to the file to be published. Can be specified
99
# action=svnunpublish: Set the "published" flag on a file to False.
100
# path: The path to the file to be unpublished. Can be specified
103
# action=svncommit: Commit a file(s) or directory(s) to the repository.
104
# path: The path to the file or directory to be committed. Can be
105
# specified multiple times. Directories are committed
107
# logmsg: Text of the log message. Optional. There is a default log
108
# message if unspecified.
109
# action=svncheckout: Checkout a file/directory from the repository.
110
# path: The [repository] path to the file or directory to be
113
# action=svnrepomkdir: Create a directory in a repository (not WC).
114
# path: The path to the directory to be created (under the IVLE
116
# logmsg: Text of the log message.
118
# action=svnrepostat: Check if a path exists in a repository (not WC).
119
# path: The path to the directory to be checked (under the IVLE
122
# TODO: Implement the following actions:
124
# TODO: Implement ZIP unpacking in putfiles (done?).
125
# TODO: svnupdate needs a digest to tell the user the files that were updated.
126
# This can be implemented by some message passing between action and
127
# listing, and having the digest included in the listing. (Problem if
128
# the listing is not a directory, but we could make it an error to do an
129
# update if the path is not a directory).
137
from ivle import (util, studpath, zip)
140
def get_login(_realm, existing_login, _may_save):
141
"""Callback function used by pysvn for authentication.
142
realm, existing_login, _may_save: The 3 arguments passed by pysvn to
144
The following has been determined empirically, not from docs:
145
existing_login will be the name of the user who owns the process on
146
the first attempt, "" on subsequent attempts. We use this fact.
148
# Only provide credentials on the _first_ attempt.
149
# If we're being asked again, then it means the credentials failed for
150
# some reason and we should just fail. (This is not desirable, but it's
151
# better than being asked an infinite number of times).
152
return (existing_login != "", ivle.conf.login, ivle.conf.svn_pass, True)
154
# Make a Subversion client object
155
svnclient = pysvn.Client()
156
svnclient.callback_get_login = get_login
157
svnclient.exception_style = 0 # Simple (string) exceptions
159
DEFAULT_LOGMESSAGE = "No log message supplied."
162
# application/json is the "best" content type but is not good for
163
# debugging because Firefox just tries to download it
164
mime_dirlisting = "text/html"
165
#mime_dirlisting = "application/json"
167
class ActionError(Exception):
168
"""Represents an error processing an action. This can be
169
raised by any of the action functions, and will be caught
170
by the top-level handler, put into the HTTP response field,
173
Important Security Consideration: The message passed to this
174
exception will be relayed to the client.
178
def handle_action(req, action, fields):
179
"""Perform the "action" part of the response.
180
This function should only be called if the response is a POST.
181
This performs the action's side-effect on the server. If unsuccessful,
182
writes the X-IVLE-Action-Error header to the request object. Otherwise,
183
does not touch the request object. Does NOT write any bytes in response.
185
May throw an ActionError. The caller should put this string into the
186
X-IVLE-Action-Error header, and then continue normally.
188
action: String, the action requested. Not sanitised.
189
fields: FieldStorage object containing all arguments passed.
191
global actions_table # Table of function objects
193
action = actions_table[action]
195
# Default, just send an error but then continue
196
raise ActionError("Unknown action")
199
def actionpath_to_urlpath(req, path):
200
"""Determines the URL path (relative to the student home) upon which the
201
action is intended to act. See actionpath_to_local.
205
elif len(path) > 0 and path[0] == os.sep:
206
# Relative to student home
209
# Relative to req.path
210
return os.path.join(req.path, path)
212
def actionpath_to_local(req, path):
213
"""Determines the local path upon which an action is intended to act.
214
Note that fileservice actions accept two paths: the request path,
215
and the "path" argument given to the action.
216
According to the rules, if the "path" argument begins with a '/' it is
217
relative to the user's home; if it does not, it is relative to the
220
This resolves the path, given the request and path argument.
222
May raise an ActionError("Invalid path"). The caller is expected to
223
let this fall through to the top-level handler, where it will be
224
put into the HTTP response field. Never returns None.
228
(_, _, r) = studpath.url_to_jailpaths(actionpath_to_urlpath(req, path))
230
raise ActionError("Invalid path")
233
def movefile(req, frompath, topath, copy=False):
234
"""Performs a file move, resolving filenames, checking for any errors,
235
and throwing ActionErrors if necessary. Can also be used to do a copy
238
frompath and topath are straight paths from the client. Will be checked.
240
# TODO: Do an SVN mv if the file is versioned.
241
# TODO: Disallow tampering with student's home directory
242
if frompath is None or topath is None:
243
raise ActionError("Required field missing")
244
frompath = actionpath_to_local(req, frompath)
245
topath = actionpath_to_local(req, topath)
246
if not os.path.exists(frompath):
247
raise ActionError("The source file does not exist")
248
if os.path.exists(topath):
249
if frompath == topath:
250
raise ActionError("Source and destination are the same")
251
raise ActionError("A file already exists with that name")
255
if os.path.isdir(frompath):
256
shutil.copytree(frompath, topath)
258
shutil.copy2(frompath, topath)
260
shutil.move(frompath, topath)
262
raise ActionError("Could not move the file specified")
264
raise ActionError("Could not move the file specified")
266
def svn_movefile(req, frompath, topath, copy=False):
267
"""Performs an svn move, resolving filenames, checking for any errors,
268
and throwing ActionErrors if necessary. Can also be used to do a copy
271
frompath and topath are straight paths from the client. Will be checked.
273
if frompath is None or topath is None:
274
raise ActionError("Required field missing")
275
frompath = actionpath_to_local(req, frompath)
276
topath = actionpath_to_local(req, topath)
277
if not os.path.exists(frompath):
278
raise ActionError("The source file does not exist")
279
if os.path.exists(topath):
280
if frompath == topath:
281
raise ActionError("Source and destination are the same")
282
raise ActionError("A file already exists with that name")
286
svnclient.copy(frompath, topath)
288
svnclient.move(frompath, topath)
290
raise ActionError("Could not move the file specified")
291
except pysvn.ClientError:
292
raise ActionError("Could not move the file specified")
297
def action_delete(req, fields):
298
# TODO: Disallow removal of student's home directory
299
"""Removes a list of files or directories.
301
Reads fields: 'path' (multiple)
303
paths = fields.getlist('path')
306
path = actionpath_to_local(req, path)
308
if os.path.isdir(path):
318
raise ActionError("Could not delete the file specified")
321
"Could not delete one or more of the files specified")
323
def action_move(req, fields):
324
# TODO: Do an SVN mv if the file is versioned.
325
# TODO: Disallow tampering with student's home directory
326
"""Removes a list of files or directories.
328
Reads fields: 'from', 'to'
330
frompath = fields.getfirst('from')
331
topath = fields.getfirst('to')
332
movefile(req, frompath, topath)
334
def action_mkdir(req, fields):
335
"""Creates a directory with the given path.
338
path = fields.getfirst('path')
340
raise ActionError("Required field missing")
341
path = actionpath_to_local(req, path)
343
if os.path.exists(path):
344
raise ActionError("A file already exists with that name")
346
# Create the directory
350
raise ActionError("Could not create directory")
352
def action_putfile(req, fields):
353
"""Writes data to a file, overwriting it if it exists and creating it if
356
Reads fields: 'path', 'data' (file upload), 'overwrite'
358
# TODO: Read field "unpack".
359
# Important: Data is "None" if the file submitted is empty.
360
path = fields.getfirst('path')
361
data = fields.getfirst('data')
363
raise ActionError("Required field missing")
365
# Workaround - field reader treats "" as None, so this is the only
366
# way to allow blank file uploads
368
path = actionpath_to_local(req, path)
371
data = cStringIO.StringIO(data)
373
overwrite = fields.getfirst('overwrite')
374
if overwrite is None:
380
# Overwrite files; but can't if it's a directory
381
if os.path.isdir(path):
382
raise ActionError("A directory already exists "
385
if os.path.exists(path):
386
raise ActionError("A file already exists with that name")
388
# Copy the contents of file object 'data' to the path 'path'
390
dest = open(path, 'wb')
392
shutil.copyfileobj(data, dest)
393
except (IOError, OSError), e:
394
raise ActionError("Could not write to target file: %s" % e.strerror)
396
def action_putfiles(req, fields):
397
"""Writes data to one or more files in a directory, overwriting them if
400
Reads fields: 'path', 'data' (file upload, multiple), 'unpack'
403
# Important: Data is "None" if the file submitted is empty.
404
path = fields.getfirst('path')
405
data = fields['data']
406
if type(data) != type([]):
408
unpack = fields.getfirst('unpack')
414
raise ActionError("Required field missing")
415
path = actionpath_to_urlpath(req, path)
419
# Each of the uploaded files
420
filepath = os.path.join(path, datum.filename)
421
filedata = datum.file
423
if unpack and datum.filename.lower().endswith(".zip"):
424
# A zip file - unpack it instead of just copying
425
# TODO: Use the magic number instead of file extension
426
# Note: Just unzip into the current directory (ignore the
429
# First get the entire path (within jail)
430
_, _, abspath = studpath.url_to_jailpaths(path)
431
abspath = os.path.join(os.sep, abspath)
432
zip.unzip(abspath, filedata)
433
except (OSError, IOError):
437
(_, _, filepath_local) = studpath.url_to_jailpaths(filepath)
438
if filepath_local is None:
439
raise ActionError("Invalid path")
441
# Copy the contents of file object 'data' to the path 'path'
443
dest = open(filepath_local, 'wb')
445
shutil.copyfileobj(filedata, dest)
446
except (OSError, IOError):
447
# TODO: Be more descriptive.
452
raise ActionError("Could not write to target file")
455
"Could not write to one or more of the target files")
457
def action_paste(req, fields):
458
"""Performs the copy or move action with the files specified.
459
Copies/moves the files to the specified directory.
461
Reads fields: 'src', 'dst', 'mode', 'file' (multiple).
462
src: Base path that all the files are relative to (source).
463
dst: Destination path to paste into.
464
mode: 'copy' or 'move'.
465
file: (Multiple) Files relative to base, which will be copied
466
or moved to new locations relative to path.
470
dst = fields.getfirst('dst')
471
src = fields.getfirst('src')
472
mode = fields.getfirst('mode')
473
files = fields.getlist('file')
474
if dst is None or src is None or mode is None:
475
raise ActionError("Required field missing")
477
dst_local = actionpath_to_local(req, dst)
478
if not os.path.isdir(dst_local):
479
raise ActionError("dst is not a directory")
483
# The source must not be interpreted as relative to req.path
484
# Add a slash (relative to top-level)
487
frompath = os.path.join(src, file)
488
# The destination is found by taking just the basename of the file
489
topath = os.path.join(dst, os.path.basename(file))
492
movefile(req, frompath, topath, True)
494
movefile(req, frompath, topath, False)
495
elif mode == "svncopy":
496
svn_movefile(req, frompath, topath, True)
497
elif mode == "svnmove":
498
svn_movefile(req, frompath, topath, False)
500
raise ActionError("Invalid mode (must be '(svn)copy' or '(svn)move')")
501
except ActionError, message:
502
# Store the error for later; we want to copy as many as possible
506
# Multiple errors; generic message
507
errormsg = "One or more files could not be pasted"
508
# Add this file to errorfiles; it will be put back on the
509
# clipboard for possible future pasting.
510
errorfiles.append(file)
511
if errormsg is not None:
512
raise ActionError(errormsg)
514
# XXX errorfiles contains a list of files that couldn't be pasted.
515
# we currently do nothing with this.
517
def action_publish(req,fields):
518
"""Marks the folder as published by adding a '.published' file to the
519
directory and ensuring that the parent directory permissions are correct
523
paths = fields.getlist('path')
524
user = studpath.url_to_local(req.path)[0]
525
homedir = "/home/%s" % user
527
paths = map(lambda path: actionpath_to_local(req, path), paths)
529
paths = [studpath.url_to_jailpaths(req.path)[2]]
531
# Set all the dirs in home dir world browsable (o+r,o+x)
532
#FIXME: Should really only do those in the direct path not all of the
533
# folders in a students home directory
534
for root,dirs,files in os.walk(homedir):
535
os.chmod(root, os.stat(root).st_mode|0005)
539
if os.path.isdir(path):
540
pubfile = open(os.path.join(path,'.published'),'w')
541
pubfile.write("This directory is published\n")
544
raise ActionError("Can only publish directories")
546
raise ActionError("Directory could not be published")
548
def action_unpublish(req,fields):
549
"""Marks the folder as unpublished by removing a '.published' file in the
550
directory (if it exits). It does not change the permissions of the parent
555
paths = fields.getlist('path')
557
paths = map(lambda path: actionpath_to_local(req, path), paths)
559
paths = [studpath.url_to_jailpaths(req.path)[2]]
563
if os.path.isdir(path):
564
pubfile = os.path.join(path,'.published')
565
if os.path.isfile(pubfile):
568
raise ActionError("Can only unpublish directories")
570
raise ActionError("Directory could not be unpublished")
573
def action_svnadd(req, fields):
574
"""Performs a "svn add" to each file specified.
576
Reads fields: 'path' (multiple)
578
paths = fields.getlist('path')
579
paths = map(lambda path: actionpath_to_local(req, path), paths)
582
svnclient.add(paths, recurse=True, force=True)
583
except pysvn.ClientError, e:
584
raise ActionError(str(e))
586
def action_svnremove(req, fields):
587
"""Performs a "svn remove" on each file specified.
589
Reads fields: 'path' (multiple)
591
paths = fields.getlist('path')
592
paths = map(lambda path: actionpath_to_local(req, path), paths)
595
svnclient.remove(paths, force=True)
596
except pysvn.ClientError, e:
597
raise ActionError(str(e))
599
def action_svnupdate(req, fields):
600
"""Performs a "svn update" to each file specified.
604
path = fields.getfirst('path')
606
raise ActionError("Required field missing")
607
path = actionpath_to_local(req, path)
610
svnclient.update(path, recurse=True)
611
except pysvn.ClientError, e:
612
raise ActionError(str(e))
614
def action_svnresolved(req, fields):
615
"""Performs a "svn resolved" to each file specified.
619
path = fields.getfirst('path')
621
raise ActionError("Required field missing")
622
path = actionpath_to_local(req, path)
625
svnclient.resolved(path, recurse=True)
626
except pysvn.ClientError, e:
627
raise ActionError(str(e))
629
def action_svnrevert(req, fields):
630
"""Performs a "svn revert" to each file specified.
632
Reads fields: 'path' (multiple)
634
paths = fields.getlist('path')
635
paths = map(lambda path: actionpath_to_local(req, path), paths)
638
svnclient.revert(paths, recurse=True)
639
except pysvn.ClientError, e:
640
raise ActionError(str(e))
642
def action_svnpublish(req, fields):
643
"""Sets svn property "ivle:published" on each file specified.
644
Should only be called on directories (only effective on directories
649
XXX Currently unused by the client (calls action_publish instead, which
650
has a completely different publishing model).
652
paths = fields.getlist('path')
654
paths = map(lambda path: actionpath_to_local(req, path), paths)
656
paths = [studpath.url_to_jailpaths(req.path)[2]]
660
# Note: Property value doesn't matter
661
svnclient.propset("ivle:published", "", path, recurse=False)
662
except pysvn.ClientError, e:
663
raise ActionError("Directory could not be published")
665
def action_svnunpublish(req, fields):
666
"""Deletes svn property "ivle:published" on each file specified.
670
XXX Currently unused by the client (calls action_unpublish instead, which
671
has a completely different publishing model).
673
paths = fields.getlist('path')
674
paths = map(lambda path: actionpath_to_local(req, path), paths)
678
svnclient.propdel("ivle:published", path, recurse=False)
679
except pysvn.ClientError, e:
680
raise ActionError("Directory could not be unpublished")
682
def action_svncommit(req, fields):
683
"""Performs a "svn commit" to each file specified.
685
Reads fields: 'path' (multiple), 'logmsg' (optional)
687
paths = fields.getlist('path')
688
paths = map(lambda path: actionpath_to_local(req, str(path)), paths)
689
logmsg = str(fields.getfirst('logmsg', DEFAULT_LOGMESSAGE))
690
if logmsg == '': logmsg = DEFAULT_LOGMESSAGE
693
svnclient.checkin(paths, logmsg, recurse=True)
694
except pysvn.ClientError, e:
695
raise ActionError(str(e))
697
def action_svncheckout(req, fields):
698
"""Performs a "svn checkout" of the first path into the second path.
700
Reads fields: 'path' (multiple)
702
paths = fields.getlist('path')
704
raise ActionError("usage: svncheckout url local-path")
705
url = ivle.conf.svn_addr + "/" + paths[0]
706
local_path = actionpath_to_local(req, str(paths[1]))
708
svnclient.callback_get_login = get_login
709
svnclient.checkout(url, local_path, recurse=True)
710
except pysvn.ClientError, e:
711
raise ActionError(str(e))
713
def action_svnrepomkdir(req, fields):
714
"""Performs a "svn mkdir" on a path under the IVLE SVN root.
718
path = fields.getfirst('path')
719
logmsg = fields.getfirst('logmsg')
720
url = ivle.conf.svn_addr + "/" + path
722
svnclient.callback_get_login = get_login
723
svnclient.mkdir(url, log_message=logmsg)
724
except pysvn.ClientError, e:
725
raise ActionError(str(e))
727
def action_svnrepostat(req, fields):
728
"""Discovers whether a path exists in a repo under the IVLE SVN root.
732
path = fields.getfirst('path')
733
url = ivle.conf.svn_addr + "/" + path
734
svnclient.exception_style = 1
737
svnclient.callback_get_login = get_login
739
except pysvn.ClientError, e:
740
# Error code 170000 means ENOENT in this revision.
741
if e[1][0][1] == 170000:
742
raise util.IVLEError(404, 'The specified repository path does not exist')
744
raise ActionError(str(e[0]))
747
# Table of all action functions #
748
# Each function has the interface f(req, fields).
751
"delete" : action_delete,
752
"move" : action_move,
753
"mkdir" : action_mkdir,
754
"putfile" : action_putfile,
755
"putfiles" : action_putfiles,
756
"paste" : action_paste,
757
"publish" : action_publish,
758
"unpublish" : action_unpublish,
760
"svnadd" : action_svnadd,
761
"svnremove" : action_svnremove,
762
"svnupdate" : action_svnupdate,
763
"svnresolved" : action_svnresolved,
764
"svnrevert" : action_svnrevert,
765
"svnpublish" : action_svnpublish,
766
"svnunpublish" : action_svnunpublish,
767
"svncommit" : action_svncommit,
768
"svncheckout" : action_svncheckout,
769
"svnrepomkdir" : action_svnrepomkdir,
770
"svnrepostat" : action_svnrepostat,
added
removed
ivle/fileservice_lib/action.py
