- Committer: dcoles
- Date: 2008-05-09 07:43:37 UTC
- Revision ID: svn-v3-trunk0:2b9c9e99-6f39-0410-b283-7f802c844ae2:trunk:753
Upload: Patch submitted by 'wagrant' to fix file upload of dos formated files
and prevent corruption of upload files.
wagrant wrote:
> Last night I set up IVLE in my Gutsy schroot, and debugged it further.
> Looking deeper at the code, I noted it was a different error from the one I
> thought it was (an incorrect header, rather than lack of a Content-Type).
> This made the cause and fix obvious.
>
> http://qeuni.net/ivle_bug_1942845.diff fixes it for me in all the
> situations I can think of. It checks for the length of the header section
> obtained by splitting on a double LF then double CRLF, and takes the
> smaller one as the headers. In the old code, any output with a double CRLF
> in the body would have anything before the first CRLF treated as headers,
> which is wrong. Double LFs weren't affected because LFs are used by default
> to terminate the real headers.
>
> I apparently can't attach things (argh! I hate the SourceForge bug
> tracker).
and prevent corruption of upload files.
wagrant wrote:
> Last night I set up IVLE in my Gutsy schroot, and debugged it further.
> Looking deeper at the code, I noted it was a different error from the one I
> thought it was (an incorrect header, rather than lack of a Content-Type).
> This made the cause and fix obvious.
>
> http://qeuni.net/ivle_bug_1942845.diff fixes it for me in all the
> situations I can think of. It checks for the length of the header section
> obtained by splitting on a double LF then double CRLF, and takes the
> smaller one as the headers. In the old code, any output with a double CRLF
> in the body would have anything before the first CRLF treated as headers,
> which is wrong. Double LFs weren't affected because LFs are used by default
> to terminate the real headers.
>
> I apparently can't attach things (argh! I hate the SourceForge bug
> tracker).
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
diff.php |
443 | 17 years ago | dcoles | Added Forum application along with unmodifed versi | 14.5 KB |
|
|
|
engine.php |
443 | 17 years ago | dcoles | Added Forum application along with unmodifed versi | 12.7 KB |
|
|
|
renderer.php |
443 | 17 years ago | dcoles | Added Forum application along with unmodifed versi | 17.6 KB |
|
|