~drizzle-trunk/drizzle/development : changes

~drizzle-trunk/drizzle/development » Changes from revision 1200.2.1

From Revision 1200.2.1 to 1182

Rev	Summary	Authors	Date
1200.2.1	Fixes a few things I found on reviewing a recent commit: Fixes a few things I found on reviewing a recent commit: a) Variable names should not include the type of the variable. There were some new variables called vector_of_engines, vector_of_transactional_engines, set_of_table_definition_ext which I changed to reflect our normal naming practices. The reason we do not prefix variable names with the type of the variable is that this means the variable name is not future-proof. If another developer wants to use a set instead of a vector for the variable in the future, then the variable name has to be changed needlessly. The purpose of the standard template library is to templatize containers so that they act much like each other and follow standard interfaces. Naming variables with a type prefix takes away this generalization. b) Removes the std:: prefix used in various places in drizzled/plugin/storage_engine.cc. Per the style guide, these are not necessary. c) Corrects an improper use of vector<>.clear() in plugin::StorageEngine::removePlugin(). The code was incorrectly calling vector<>.clear() instead of vector<>.erase(). d) Removes the fn_rext() function which was removed in a recent commit and re-added in this later commit, presumably because the commit was not merged up with trunk.	Jay Pipes	15 years ago
1200	Clean up some mispellings Clean up some mispellings	Brian Aker	15 years ago
1199	Fix comment. Fix comment.	Brian Aker	15 years ago
1198	Merge Brian Merge Brian	Brian Aker	15 years ago
1197	Remove test for 32bit max on heap tables. Remove test for 32bit max on heap tables. Yeah... set the HEAP table to max on a 32bit machine and watch the Piñata go. The value shouldn't be max, but should be some number less then MAX... aka don't let the user blow up.	Brian Aker	15 years ago
1196	Small fixes Small fixes	Brian Aker	15 years ago
1195	Merge Diego Merge Diego	Brian Aker	15 years ago
1194	Removed test for ARCH (it only looked at Intel style systems... Removed test for ARCH (it only looked at Intel style systems). Left in SELECT for it.	Brian Aker	15 years ago
1193	Merge Jay Merge Jay	Brian Aker	15 years ago
1192	Merge Stewart's dead code removal Merge Stewart's dead code removal	Brian Aker	15 years ago
1191	Adding test cases that came from SergP. Adding test cases that came from SergP.	Brian Aker	15 years ago
1190	Merge Jay. Merge Jay.	Brian Aker	15 years ago
1189	Adding in memcached_functions Adding in memcached_functions	Brian Aker	15 years ago
1188	Merge Stewart Merge Stewart	Brian Aker	15 years ago
1187	Merge Jay Merge Jay	Brian Aker	15 years ago
1186	Merge of Monty Merge of Monty	Brian Aker	15 years ago
1185	Merge Engine changes. Merge Engine changes.	Brian Aker	15 years ago
1184	Merge memory Merge memory	Brian Aker	15 years ago
1183	Merge Monty Merge Monty	Brian Aker	15 years ago
1182	Minor Merge Minor Merge	Brian Aker	15 years ago

Older »