~drizzle-trunk/drizzle/development

« back to all changes in this revision

Viewing changes to drizzled/parser.h

  • Committer: Prafulla Tekawade
  • Date: 2010-07-18 03:36:32 UTC
  • mto: (1662.1.4 rollup)
  • mto: This revision was merged to the branch mainline in revision 1664.
  • Revision ID: prafulla_t@users.sourceforge.net-20100718033632-p7q6qtgliqbhe38p
Fix for Bug 592444

There were two problems:
o. In greedy_search optimizer method, best_extension_by_limited search
   maintains join embedding(nestedness) of tables added so far, so that 
   correct(valid)  join order is selected
   These are requirements from nested outer join executioner.
   The problem was, embedding_map was not correctly updated when a table 
   is added to optimal plan outside best_extension_by_limited search, 
   by greedy_search method. We need to update join->cur_embedding_map
   correctly here so that execution plan for other tables get
   generated.
   Invoked checked_interleaving_with_nj from greedy_search on the
   best_table selected. Fixed its prototype to take only one JoinTab
   This is same as mysql 5.1 source tree.
o. The other problem was, join->cur_embedding_map was not restored correctly
   when a table is added to the optimal plan to reflect the current embedding 
   map. 
   Taken good documented method restore_prev_nj_state which restores 
   cur_embedding_map from mysql 5.1 source tree and modified it for drizzled 
   code.

Show diffs side-by-side

added added

removed removed

Lines of Context:
11
11
 
12
12
   You should have received a copy of the GNU General Public License
13
13
   along with this program; if not, write to the Free Software
14
 
   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA */
 
14
   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA */
15
15
 
16
16
#ifndef DRIZZLED_PARSER_H
17
17
#define DRIZZLED_PARSER_H
77
77
#include <drizzled/statement/drop_schema.h>
78
78
#include <drizzled/statement/drop_table.h>
79
79
#include <drizzled/statement/empty_query.h>
80
 
#include <drizzled/statement/execute.h>
81
80
#include <drizzled/statement/flush.h>
82
81
#include <drizzled/statement/insert.h>
83
82
#include <drizzled/statement/insert_select.h>
91
90
#include <drizzled/statement/rollback_to_savepoint.h>
92
91
#include <drizzled/statement/savepoint.h>
93
92
#include <drizzled/statement/select.h>
94
 
#include <drizzled/statement/show.h>
95
93
#include <drizzled/statement/set_option.h>
 
94
#include <drizzled/statement/show_create.h>
 
95
#include <drizzled/statement/show_create_schema.h>
96
96
#include <drizzled/statement/show_errors.h>
97
97
#include <drizzled/statement/show_warnings.h>
98
98
#include <drizzled/statement/start_transaction.h>