1
dnl Copyright (C) 2009 Sun Microsystems, Inc.
2
dnl This file is free software; Sun Microsystems, Inc.
3
dnl gives unlimited permission to copy and/or distribute it,
4
dnl with or without modifications, as long as this notice is preserved.
6
dnl AC_PANDORA_WARNINGS([less-warnings|warnings-always-on])
7
dnl less-warnings turn on a limited set of warnings
8
dnl warnings-always-on always set warnings=error regardless of tarball/vc
10
dnl @TODO: remove less-warnings option as soon as Drizzle is clean enough to
13
AC_DEFUN([PANDORA_WARNINGS],[
14
m4_define([PW_LESS_WARNINGS],[no])
15
m4_define([PW_WARN_ALWAYS_ON],[no])
16
ifdef([m4_define],,[define([m4_define], defn([define]))])
17
ifdef([m4_undefine],,[define([m4_undefine], defn([undefine]))])
18
m4_foreach([pw_arg],[$*],[
21
m4_undefine([PW_LESS_WARNINGS])
22
m4_define([PW_LESS_WARNINGS],[yes])
24
[warnings-always-on],[
25
m4_undefine([PW_WARN_ALWAYS_ON])
26
m4_define([PW_WARN_ALWAYS_ON],[yes])
30
AC_REQUIRE([PANDORA_BUILDING_FROM_VC])
31
m4_if(PW_WARN_ALWAYS_ON, [yes],
32
[ac_cv_warnings_as_errors=yes],
33
AS_IF([test "$pandora_building_from_vc" = "yes"],
34
[ac_cv_warnings_as_errors=yes],
35
[ac_cv_warnings_as_errors=no]))
37
AC_ARG_ENABLE([profiling],
38
[AS_HELP_STRING([--enable-profiling],
39
[Toggle profiling @<:@default=off@:>@])],
40
[ac_profiling="$enableval"],
43
AC_ARG_ENABLE([coverage],
44
[AS_HELP_STRING([--enable-coverage],
45
[Toggle coverage @<:@default=off@:>@])],
46
[ac_coverage="$enableval"],
49
AS_IF([test "$GCC" = "yes"],[
51
AS_IF([test "$ac_profiling" = "yes"],[
53
GCOV_LIBS="-pg -lgcov"
56
AC_CHECK_LIB(c_p, read)
64
AS_IF([test "$ac_coverage" = "yes"],
66
CC_COVERAGE="--coverage"
72
AS_IF([test "$ac_cv_warnings_as_errors" = "yes"],
75
AC_CACHE_CHECK([whether it is safe to use -fdiagnostics-show-option],
76
[ac_cv_safe_to_use_fdiagnostics_show_option_],
77
[save_CFLAGS="$CFLAGS"
78
CFLAGS="-fdiagnostics-show-option ${AM_CFLAGS} ${CFLAGS}"
80
[AC_LANG_PROGRAM([],[])],
81
[ac_cv_safe_to_use_fdiagnostics_show_option_=yes],
82
[ac_cv_safe_to_use_fdiagnostics_show_option_=no])
83
CFLAGS="$save_CFLAGS"])
85
AS_IF([test "$ac_cv_safe_to_use_fdiagnostics_show_option_" = "yes"],
87
F_DIAGNOSTICS_SHOW_OPTION="-fdiagnostics-show-option"
90
NO_STRICT_ALIASING="-fno-strict-aliasing -Wno-strict-aliasing"
91
NO_SHADOW="-Wno-shadow"
93
AS_IF([test "$INTELCC" = "yes"],[
94
m4_if(PW_LESS_WARNINGS,[no],[
95
BASE_WARNINGS="-w1 -Werror -Wcheck -Wp64 -Woverloaded-virtual -Wcast-qual -diag-disable 188"
97
dnl 2203 is like old-style-cast
98
dnl 1684 is like strict-aliasing
99
dnl 188 is about using enums as bitfields
100
dnl 1683 is a warning about _EXPLICIT_ casting, which we want
101
BASE_WARNINGS="-w1 -Werror -Wcheck -Wp64 -Woverloaded-virtual -Wcast-qual -diag-disable 188,981,2259,2203,1683,1684"
103
CC_WARNINGS="${BASE_WARNINGS}"
104
CXX_WARNINGS="${BASE_WARNINGS}"
105
PROTOSKIP_WARNINGS="-diag-disable 188,981,967,2259,1683,1684,2203"
108
m4_if(PW_LESS_WARNINGS,[no],[
109
BASE_WARNINGS_FULL="${W_CONVERSION} -Wstrict-aliasing"
110
CC_WARNINGS_FULL="-Wswitch-default -Wswitch-enum -Wwrite-strings"
111
CXX_WARNINGS_FULL="-Weffc++ -Wold-style-cast"
112
NO_OLD_STYLE_CAST="-Wno-old-style-cast"
113
NO_EFF_CXX="-Wno-effc++"
115
BASE_WARNINGS_FULL="${NO_STRICT_ALIASING}"
118
AS_IF([test "${ac_cv_assert}" = "no"],
119
[NO_UNUSED="-Wno-unused-variable -Wno-unused-parameter"])
121
AC_CACHE_CHECK([whether it is safe to use -Wextra],
122
[ac_cv_safe_to_use_Wextra_],
123
[save_CFLAGS="$CFLAGS"
124
CFLAGS="${W_FAIL} -pedantic -Wextra ${AM_CFLAGS} ${CFLAGS}"
131
[ac_cv_safe_to_use_Wextra_=yes],
132
[ac_cv_safe_to_use_Wextra_=no])
133
CFLAGS="$save_CFLAGS"])
135
BASE_WARNINGS="${W_FAIL} -pedantic -Wall -Wundef -Wshadow ${NO_UNUSED} ${F_DIAGNOSTICS_SHOW_OPTION} ${BASE_WARNINGS_FULL}"
136
AS_IF([test "$ac_cv_safe_to_use_Wextra_" = "yes"],
137
[BASE_WARNINGS="${BASE_WARNINGS} -Wextra"],
138
[BASE_WARNINGS="${BASE_WARNINGS} -W"])
140
AC_CACHE_CHECK([whether it is safe to use -Wformat],
141
[ac_cv_safe_to_use_wformat_],
142
[save_CFLAGS="$CFLAGS"
143
dnl Use -Werror here instead of ${W_FAIL} so that we don't spew
144
dnl conversion warnings to all the tarball folks
145
CFLAGS="-Wformat -Werror -pedantic ${AM_CFLAGS} ${CFLAGS}"
150
#include <inttypes.h>
155
printf("This is a %" PRIu64 "test\n", test_u);
160
[ac_cv_safe_to_use_wformat_=yes],
161
[ac_cv_safe_to_use_wformat_=no])
162
CFLAGS="$save_CFLAGS"])
163
AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[
164
BASE_WARNINGS="${BASE_WARNINGS} -Wformat -Wno-format-nonliteral -Wno-format-security"
165
BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2 -Wno-format-nonliteral -Wno-format-security"
167
BASE_WARNINGS="${BASE_WARNINGS} -Wno-format"
168
BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format"
173
AC_CACHE_CHECK([whether it is safe to use -Wconversion],
174
[ac_cv_safe_to_use_wconversion_],
175
[save_CFLAGS="$CFLAGS"
176
dnl Use -Werror here instead of ${W_FAIL} so that we don't spew
177
dnl conversion warnings to all the tarball folks
178
CFLAGS="-Wconversion -Werror -pedantic ${AM_CFLAGS} ${CFLAGS}"
189
[ac_cv_safe_to_use_wconversion_=yes],
190
[ac_cv_safe_to_use_wconversion_=no])
191
CFLAGS="$save_CFLAGS"])
193
AS_IF([test "$ac_cv_safe_to_use_wconversion_" = "yes"],
194
[W_CONVERSION="-Wconversion"
195
AC_CACHE_CHECK([whether it is safe to use -Wconversion with htons],
196
[ac_cv_safe_to_use_Wconversion_],
197
[save_CFLAGS="$CFLAGS"
198
dnl Use -Werror here instead of ${W_FAIL} so that we don't spew
199
dnl conversion warnings to all the tarball folks
200
CFLAGS="-Wconversion -Werror -pedantic ${AM_CFLAGS} ${CFLAGS}"
204
#include <netinet/in.h>
206
uint16_t x= htons(80);
208
[ac_cv_safe_to_use_Wconversion_=yes],
209
[ac_cv_safe_to_use_Wconversion_=no])
210
CFLAGS="$save_CFLAGS"])
212
AS_IF([test "$ac_cv_safe_to_use_Wconversion_" = "no"],
213
[NO_CONVERSION="-Wno-conversion"])
216
CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}"
217
CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long ${CXX_WARNINGS_FULL}"
219
AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++],
220
[ac_cv_safe_to_use_Wmissing_declarations_],
222
save_CXXFLAGS="$CXXFLAGS"
223
CXXFLAGS="-Werror -pedantic -Wmissing-declarations ${AM_CXXFLAGS}"
230
[ac_cv_safe_to_use_Wmissing_declarations_=yes],
231
[ac_cv_safe_to_use_Wmissing_declarations_=no])
232
CXXFLAGS="$save_CXXFLAGS"
235
AS_IF([test "$ac_cv_safe_to_use_Wmissing_declarations_" = "yes"],
236
[CXX_WARNINGS="${CXX_WARNINGS} -Wmissing-declarations"])
238
AC_CACHE_CHECK([whether it is safe to use -Wframe-larger-than],
239
[ac_cv_safe_to_use_Wframe_larger_than_],
241
save_CXXFLAGS="$CXXFLAGS"
242
CXXFLAGS="-Werror -pedantic -Wframe-larger-than=32768 ${AM_CXXFLAGS}"
249
[ac_cv_safe_to_use_Wframe_larger_than_=yes],
250
[ac_cv_safe_to_use_Wframe_larger_than_=no])
251
CXXFLAGS="$save_CXXFLAGS"
254
AS_IF([test "$ac_cv_safe_to_use_Wframe_larger_than_" = "yes"],
255
[CXX_WARNINGS="${CXX_WARNINGS} -Wframe-larger-than=32768"])
257
AC_CACHE_CHECK([whether it is safe to use -Wlogical-op],
258
[ac_cv_safe_to_use_Wlogical_op_],
259
[save_CFLAGS="$CFLAGS"
260
CFLAGS="${W_FAIL} -pedantic -Wlogical-op ${AM_CFLAGS} ${CFLAGS}"
267
[ac_cv_safe_to_use_Wlogical_op_=yes],
268
[ac_cv_safe_to_use_Wlogical_op_=no])
269
CFLAGS="$save_CFLAGS"])
270
AS_IF([test "$ac_cv_safe_to_use_Wlogical_op_" = "yes"],
271
[CC_WARNINGS="${CC_WARNINGS} -Wlogical-op"])
273
AC_CACHE_CHECK([whether it is safe to use -Wredundant-decls from C++],
274
[ac_cv_safe_to_use_Wredundant_decls_],
276
save_CXXFLAGS="${CXXFLAGS}"
277
CXXFLAGS="${W_FAIL} -pedantic -Wredundant-decls ${AM_CXXFLAGS}"
280
template <typename E> struct C { void foo(); };
281
template <typename E> void C<E>::foo() { }
282
template <> void C<int>::foo();
283
AC_INCLUDES_DEFAULT])],
284
[ac_cv_safe_to_use_Wredundant_decls_=yes],
285
[ac_cv_safe_to_use_Wredundant_decls_=no])
286
CXXFLAGS="${save_CXXFLAGS}"
288
AS_IF([test "$ac_cv_safe_to_use_Wredundant_decls_" = "yes"],
289
[CXX_WARNINGS="${CXX_WARNINGS} -Wredundant-decls"],
290
[CXX_WARNINGS="${CXX_WARNINGS} -Wno-redundant-decls"])
292
AC_CACHE_CHECK([whether it is safe to use -Wattributes from C++],
293
[ac_cv_safe_to_use_Wattributes_],
295
save_CXXFLAGS="${CXXFLAGS}"
296
CXXFLAGS="${W_FAIL} -pedantic -Wattributes -fvisibility=hidden ${AM_CXXFLAGS}"
299
#include <google/protobuf/message.h>
300
#include <google/protobuf/descriptor.h>
303
const ::google::protobuf::EnumDescriptor* Table_TableOptions_RowType_descriptor();
304
enum Table_TableOptions_RowType {
305
Table_TableOptions_RowType_ROW_TYPE_DEFAULT = 0,
306
Table_TableOptions_RowType_ROW_TYPE_FIXED = 1,
307
Table_TableOptions_RowType_ROW_TYPE_DYNAMIC = 2,
308
Table_TableOptions_RowType_ROW_TYPE_COMPRESSED = 3,
309
Table_TableOptions_RowType_ROW_TYPE_REDUNDANT = 4,
310
Table_TableOptions_RowType_ROW_TYPE_COMPACT = 5,
311
Table_TableOptions_RowType_ROW_TYPE_PAGE = 6
317
inline const EnumDescriptor* GetEnumDescriptor<Table_TableOptions_RowType>() {
318
return Table_TableOptions_RowType_descriptor();
323
[ac_cv_safe_to_use_Wattributes_=yes],
324
[ac_cv_safe_to_use_Wattributes_=no])
325
CXXFLAGS="${save_CXXFLAGS}"
327
AC_CACHE_CHECK([whether it is safe to use -Wno-attributes],
328
[ac_cv_safe_to_use_Wno_attributes_],
329
[save_CFLAGS="$CFLAGS"
330
CFLAGS="${W_FAIL} -pedantic -Wno_attributes_ ${AM_CFLAGS} ${CFLAGS}"
337
[ac_cv_safe_to_use_Wno_attributes_=yes],
338
[ac_cv_safe_to_use_Wno_attributes_=no])
339
CFLAGS="$save_CFLAGS"])
341
dnl GCC 3.4 doesn't have -Wno-attributes, so we can't turn them off
343
AS_IF([test "$ac_cv_safe_to_use_Wattributes_" != "yes"],[
344
AS_IF([test "$ac_cv_safe_to_use_Wno_attributes_" = "yes"],[
345
CC_WARNINGS="${CC_WARNINGS} -Wno-attributes"
346
NO_ATTRIBUTES="-Wno-attributes"])])
349
NO_REDUNDANT_DECLS="-Wno-redundant-decls"
350
dnl TODO: Figure out a better way to deal with this:
351
PROTOSKIP_WARNINGS="-Wno-effc++ -Wno-shadow -Wno-missing-braces ${NO_ATTRIBUTES}"
352
NO_WERROR="-Wno-error"
353
INNOBASE_SKIP_WARNINGS="-Wno-shadow -Wno-cast-align"
354
AS_IF([test "$host_vendor" = "apple"],[
355
BOOSTSKIP_WARNINGS="-Wno-uninitialized"
360
AS_IF([test "$SUNCC" = "yes"],[
362
AS_IF([test "$ac_profiling" = "yes"],
363
[CC_PROFILING="-xinstrument=datarace"])
365
AS_IF([test "$ac_cv_warnings_as_errors" = "yes"],
366
[W_FAIL="-errwarn=%all"])
368
AC_CACHE_CHECK([whether E_PASTE_RESULT_NOT_TOKEN is usable],
369
[ac_cv_paste_result],
371
save_CFLAGS="${CFLAGS}"
372
CFLAGS="-errwarn=%all -erroff=E_PASTE_RESULT_NOT_TOKEN ${CFLAGS}"
378
[ac_cv_paste_result=yes],
379
[ac_cv_paste_result=no])
380
CFLAGS="${save_CFLAGS}"
382
AS_IF([test $ac_cv_paste_result = yes],
383
[W_PASTE_RESULT=",E_PASTE_RESULT_NOT_TOKEN"])
386
m4_if(PW_LESS_WARNINGS, [no],[
387
CC_WARNINGS_FULL="-erroff=E_INTEGER_OVERFLOW_DETECTED${W_PASTE_RESULT}"
388
CXX_WARNINGS_FULL="-erroff=inllargeuse"
390
CC_WARNINGS_FULL="-erroff=E_ATTRIBUTE_NOT_VAR"
391
CXX_WARNINGS_FULL="-erroff=attrskipunsup,doubunder,reftotemp,inllargeuse,truncwarn1,signextwarn,inllargeint"
394
CC_WARNINGS="-v -errtags=yes ${W_FAIL} ${CC_WARNINGS_FULL}"
395
CXX_WARNINGS="+w +w2 -xwe -xport64 -errtags=yes ${CXX_WARNINGS_FULL} ${W_FAIL}"
396
PROTOSKIP_WARNINGS="-erroff=attrskipunsup,doubunder,reftotemp,wbadinitl,identexpected,inllargeuse,truncwarn1,signextwarn,partinit,notused,badargtype2w,wbadinit"
397
BOOSTSKIP_WARNINGS="-erroff=attrskipunsup,doubunder,reftotemp,inllargeuse,truncwarn1,signextwarn,inllargeint,hidef,wvarhidenmem"
398
NO_UNREACHED="-erroff=E_STATEMENT_NOT_REACHED"
399
NO_WERROR="-errwarn=%none"
403
AC_SUBST(NO_CONVERSION)
404
AC_SUBST(NO_REDUNDANT_DECLS)
405
AC_SUBST(NO_UNREACHED)
407
AC_SUBST(NO_STRICT_ALIASING)
409
AC_SUBST(NO_OLD_STYLE_CAST)
410
AC_SUBST(PROTOSKIP_WARNINGS)
411
AC_SUBST(BOOSTSKIP_WARNINGS)
412
AC_SUBST(INNOBASE_SKIP_WARNINGS)
414
AC_SUBST([GCOV_LIBS])