« back to all changes in this revision
Viewing changes to drizzled/sql_select.cc
- Committer: Padraig
- Date: 2009-02-13 08:26:21 UTC
- mto: (873.2.28 devel)
- mto: This revision was merged to the branch mainline in revision 885.
- Revision ID: posulliv@linux-lap-20090213082621-510acwp4j58z3qzc
Updated the fix for Bug#319796.
After chatting with Monty, we came to the conclusion that there is not much
of a need for enforcing a limit on the column alias length. Thus, we removed
the check that the length is less than MAX_ALIAS_LENGTH in Item::set_name.
We also removed all references to MAX_ALIAS_NAME in the code. It was only
used as fixed-length buffer in a few utility functions as a temporary place
for performing lower-case operations. We replaced these lower-case
operations with the transform operations and used std::string's instead of
fixed-length buffers.
Thus, we were able to resolve this bug by actually removing some code :)
After chatting with Monty, we came to the conclusion that there is not much
of a need for enforcing a limit on the column alias length. Thus, we removed
the check that the length is less than MAX_ALIAS_LENGTH in Item::set_name.
We also removed all references to MAX_ALIAS_NAME in the code. It was only
used as fixed-length buffer in a few utility functions as a temporary place
for performing lower-case operations. We replaced these lower-case
operations with the transform operations and used std::string's instead of
fixed-length buffers.
Thus, we were able to resolve this bug by actually removing some code :)
- files modified:
- drizzled/item.cc
added
removed
drizzled/sql_select.cc
