~launchpad-pqm/launchpad/devel

First cut of the email interface! Refactorings to SQLObjectFooEvents. First cut of banzai deeath scene. Fix bug 931. Add bug url declarations. And some more... r=stevea
Patches applied:

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--base-0
   tag of bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-79

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-1
   improve readability in doctest.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-2
   get is not a search method.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-3
   initial support for commenting. add 'filealias' to IEmailHandler.process().

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-4
   set the correct parent when converting an email.Message to an IMessage.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-5
   add commented out test and XXX.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-6
   pass the to-address to the handler.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-7
   don't require BugFactory to create a task. move that check to an ObjectCreatedEvent subscriber instead.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-8
   add default values to createTask, cleanup.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-9
   simplify the command parsing. make commenting and simple bug edit work.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-10
   remove unneeded arguments from BugFactory. improve docstring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-11
   cleanup error handling.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-12
   make basic editing of bug and bug tasks work while commenting. fire off the right events to make bug privacy work.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-13
   checkpoint in refactoring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-14
   checkpoint in refactoring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-15
   more refactoring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-16
   add helper function get_attribute_names. make sure doctests in helpers.py get run

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-17
   major refactoring of command handling.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-18
   return a real event, not just the class and arguments.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-19
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-20
   cleanup, add/fix docstrings.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-21
   add get_attribute_names again.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-22
   factor out common functionality into helpers.py

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-23
   fix broken tests.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-24
   improve handling of commands.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-25
   typo

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-26
   improve emailinterface.txt

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-27
   fix failing tests.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-28
   abort the transaction on failures

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-29
   add subscribe command

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-30
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-31
   merge launchpad--bug-889--0

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-32
   don't require emails to be signed for comments.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-33
   use personset, not person.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-34
   MaloneHandler implements IMailHandler

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-35
   fix indentation. proper transaction handling. return the principal for unsigned emails.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-36
   remove pdb import

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-37
   add mail-into-launchpad script

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-38
   make the from address '25239bugid@...'

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-39
   commands shouldn't be utilities.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-40
   cleanup

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-41
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-42
   merge bugfix 931

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-43
   fire off events when adding and editing subscribers.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-44
   more error checking, some cleanup.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-45
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-46
   minor cleanup

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-47
   improved checking of number of arguments.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-48
   cleanup.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-49
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-50
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-51
   add browser:url declarations for IBug and IBugSet.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-52
   nuke 'request' and 'principal' from SQLFooEvents, add 'user'. some cleanups. make BugActivity.person be a Person instead of an Int

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-53
   merge CanonicalUrls

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-54
   make bug url declarations follow the same style as the others. add examples to canonical_url_examples.txt.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-55
   use canonical_url

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-56
   improve Snapshot

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-57
   rename MaloneProcessError to IncomingEmailError

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-58
   accept email commands being indent with tabs

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-59
   add docstrings.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-60
   move _commands and its related functions to a class.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-61
   emit a warning if the email can't be converted.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-62
   move email text to an email template.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-63
   move email text to an email template.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-64
   raise more specific exceptions.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-65
   move get_object from helpers.py into pathlookup

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-66
   removed unused import.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-67
   remove database imports.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-68
   raise an exception if the signature can't be validated.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-69
   use a lockfile in the cron script.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-70
   improve docstring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-71
   add a list of email commands implemented.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-72
   raise a more specific error than ValueError.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-73
   add docstring.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-74
   make test pass.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-75
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-76
   use ILaunchpadCelebrities.

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-77
   Part -> Step

 * bjorn.tillenius@canonical.com/launchpad--CommentBugViaEmail--1--patch-78
   add missing import.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--base-0
   tag of rocketfuel@canonical.com/launchpad--devel--0--patch-1499

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-1
   initial check-in. still needs more polishing and more tests and error checking.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-2
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-3
   added some more tests.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-4
   add marker interfaces to specify the type of a directive. rename parse_directives to parse_headers.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-5
   move removeSecurityProxy call to a more appropriate place.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-6
   add some simple error checking. move back the removeSecurityProxy call.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-7
   clean up error checking code. add some more error checking.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-8
   more error checking.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-9
   more error checking. more refactoring of error checking code.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-10
   add /malone/+send-mail to the the email interface with.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-11
   oops, add missing files

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-12
   clean up

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-13
   make sure an edit notification is sent.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-14
   add MaloneHandler which chooses the correct handler.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-15
   use MaloneHandler instead of SubmitBugHandler.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-16
   rename directive to header.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-17
   checkpoint to let stevea and spiv debug test failure.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-18
   initial support for multipart messages.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-19
   merge AuthenticateEmail (together with some RF). added MockRequest to make tests happy

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-20
   make +send-mail use authenticateEmail. change process() to expect a SignedMessage.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-21
   merge AuthenticateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-22
   merge AuthenticateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-23
   merge AuthenticateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-24
   merge AuthentiateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-25
   clean up documentation and tests. make sure bug.description gets set correctly.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-26
   merge AuthenticateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-27
   check that the user is authenticated, let anonymous post emails.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-28
   return changed, not True

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-29
   remove unused imports

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-30
   merge AuthenticateGpgEmails

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-31
   use the signed content in the handler.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-32
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-33
   correct indentation.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-34
   cosmetic fix.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-35
   cosmetic fixes.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-36
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-37
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-38
   merge rf, one test failing since AuthenticateGpgEmails isn't merged yet.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-39
   merge AuthenticateGpgEmails.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-40
   merge POP3-utility

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-41
   merge POP3-utility.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-42
   merge POP3-utility

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-43
   merge launchpad-POP3-utility.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-44
   merge launchpad-POP3-utility.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-45
   merge launchpad-POP3-utility.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-46
   use IMailBox

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-47
   make BugFactory return a Bug instead of BugAdded.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-48
   bug add notificatoins should listen to IBug, not IBugAddForm

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-49
   fix failing test.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-50
   initial checkin of new approach. not all commands are implemented, and a lot of error checking and cleanup is needed.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-51
   use **bug_task_args instead of explicitely name them.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-52
   fix private command, add status command.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-53
   add missing file

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-54
   remove unused code.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-55
   remove requirement of commands being indented. add some basic error checking.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-56
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-57
   use urljoin instead of manually constructing the URL.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-58
   make test more readable.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-59
   use root_url to generate the URL in for the email interface.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-60
   remove test_headers.py

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-61
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-62
   add asserts.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-63
   remove unused import

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-64
   PEP-8

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-65
   raise better suited exceptions.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-66
   raise NotFoundError instead of KeyError.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-67
   use *Set instead of the database classes directly.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-68
   add missing imports.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-69
   add XXX, improve docstring.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-70
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-71
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-72
   initial checkin of handleMail(). still requires some sane error handling.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-73
   merge rf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-74
   add errors_address to launchpad.conf

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-75
   add basic error handling in handleMail()

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-76
   clean up

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-77
   clean up. add basic error checking.

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-78
   more cleanup

 * bjorn.tillenius@canonical.com/launchpad--SubmitBugViaEmail--0--patch-79
   fix test failure.

 * bjorn.tillenius@canonical.com/launchpad--bug-931--0--base-0
   tag of rocketfuel@canonical.com/launchpad--devel--0--patch-1821

 * bjorn.tillenius@canonical.com/launchpad--bug-931--0--patch-1
   simplify what_changed()

 * bjorn.tillenius@canonical.com/launchpad--bug-931--0--patch-2
   add test for subscription bug activity, make the test.

 * bjorn.tillenius@canonical.com/launchpad--bug-931--0--patch-3
   refactor what_changed()

 * bjorn.tillenius@canonical.com/launchpad--bug-931--0--patch-4
   rename bugwatch to bugsubscription