← Back to branch summary

~launchpad-pqm/launchpad/devel

« back to all changes in this revision

Viewing changes to lib/lp/code/xmlrpc/codehosting.py

  • Committer: Steve Kowalik
  • Date: 2011-08-07 04:05:52 UTC
  • mto: This revision was merged to the branch mainline in revision 13626.
  • Revision ID: stevenk@ubuntu.com-20110807040552-mwnxo0flmhvl35e8
Correct the notification based on review comments, and remove request{,ed}
from the function names, switching to create{,d}.

Show diffs side-by-side

added added

removed removed

Lines of Context:
lib/lp/code/xmlrpc/codehosting.py
24
24
from zope.security.management import endInteraction
25
25
from zope.security.proxy import removeSecurityProxy
26
26
 
 
27
from canonical.launchpad.webapp import LaunchpadXMLRPCView
 
28
from canonical.launchpad.webapp.authorization import check_permission
 
29
from canonical.launchpad.webapp.interaction import setupInteractionForPerson
 
30
from canonical.launchpad.xmlrpc import faults
 
31
from canonical.launchpad.xmlrpc.helpers import return_fault
27
32
from lp.app.errors import (
28
33
    NameLookupFailed,
29
34
    NotFoundError,
37
42
    NoLinkedBranch,
38
43
    UnknownBranchTypeError,
39
44
    )
 
45
from lp.code.interfaces.branch import get_db_branch_info
40
46
from lp.code.interfaces import branchpuller
41
 
from lp.code.interfaces.branch import get_db_branch_info
42
47
from lp.code.interfaces.branchlookup import (
43
48
    IBranchLookup,
44
49
    ILinkedBranchTraverser,
59
64
    LAUNCHPAD_SERVICES,
60
65
    )
61
66
from lp.code.interfaces.linkedbranch import ICanHasLinkedBranch
62
 
from lp.registry.errors import (
63
 
    InvalidName,
64
 
    NoSuchSourcePackageName,
65
 
    )
66
67
from lp.registry.interfaces.person import (
67
68
    IPersonSet,
68
69
    NoSuchPerson,
71
72
    InvalidProductName,
72
73
    NoSuchProduct,
73
74
    )
74
 
from lp.registry.interfaces.sourcepackagename import ISourcePackageNameSet
75
75
from lp.services.scripts.interfaces.scriptactivity import IScriptActivitySet
76
76
from lp.services.utils import iter_split
77
 
from lp.services.webapp import LaunchpadXMLRPCView
78
 
from lp.services.webapp.authorization import check_permission
79
 
from lp.services.webapp.interaction import setupInteractionForPerson
80
 
from lp.xmlrpc import faults
81
 
from lp.xmlrpc.helpers import return_fault
82
77
 
83
78
 
84
79
UTC = pytz.timezone('UTC')
225
220
            except NoSuchProduct, e:
226
221
                return faults.NotFound(
227
222
                    "Project '%s' does not exist." % e.name)
228
 
            except NoSuchSourcePackageName as e:
229
 
                try:
230
 
                    getUtility(ISourcePackageNameSet).new(e.name)
231
 
                except InvalidName:
232
 
                    return faults.InvalidSourcePackageName(e.name)
233
 
                return self.createBranch(login_id, branch_path)
234
223
            except NameLookupFailed, e:
235
224
                return faults.NotFound(str(e))
236
225
            try: