← Back to branch summary

~launchpad-pqm/launchpad/devel

« back to all changes in this revision

Viewing changes to lib/lp/soyuz/scripts/processaccepted.py

  • Committer: Curtis Hovey
  • Date: 2011-08-18 20:56:37 UTC
  • mto: This revision was merged to the branch mainline in revision 13736.
  • Revision ID: curtis.hovey@canonical.com-20110818205637-ae0pf9aexdea2mlb
Cleaned up doctrings and hushed lint.

Show diffs side-by-side

added added

removed removed

Lines of Context:
lib/lp/soyuz/scripts/processaccepted.py
37
37
from lp.soyuz.enums import (
38
38
    ArchivePurpose,
39
39
    PackageUploadStatus,
40
 
    re_bug_numbers,
41
 
    re_closes,
42
 
    re_lp_closes,
43
40
    )
44
41
from lp.soyuz.interfaces.archive import IArchiveSet
45
42
from lp.soyuz.interfaces.queue import IPackageUploadSet
67
64
    return bugs
68
65
 
69
66
 
70
 
def get_bugs_from_changelog_entry(sourcepackagerelease, since_version):
71
 
    """Parse the changelog_entry in the sourcepackagerelease and return a
72
 
    list of `IBug`s referenced by it.
73
 
    """
74
 
    changelog = sourcepackagerelease.aggregate_changelog(since_version)
75
 
    closes = []
76
 
    # There are 2 main regexes to match.  Each match from those can then
77
 
    # have further multiple matches from the 3rd regex:
78
 
    # closes: NNN, NNN
79
 
    # lp: #NNN, #NNN
80
 
    regexes = (
81
 
        re_closes.finditer(changelog), re_lp_closes.finditer(changelog))
82
 
    for regex in regexes:
83
 
        for match in regex:
84
 
            bug_match = re_bug_numbers.findall(match.group(0))
85
 
            closes += map(int, bug_match)
86
 
 
87
 
    bugs = []
88
 
    for bug_id in closes:
89
 
        try:
90
 
            bug = getUtility(IBugSet).get(bug_id)
91
 
        except NotFoundError:
92
 
            continue
93
 
        else:
94
 
            bugs.append(bug)
95
 
 
96
 
    return bugs
97
 
 
98
 
 
99
67
def can_close_bugs(target):
100
68
    """Whether or not bugs should be closed in the given target.
101
69
 
151
119
            source_queue_item.sourcepackagerelease, changesfile_object)
152
120
 
153
121
 
154
 
def close_bugs_for_sourcepublication(source_publication, since_version=None):
 
122
def close_bugs_for_sourcepublication(source_publication):
155
123
    """Close bugs for a given sourcepublication.
156
124
 
157
125
    Given a `ISourcePackagePublishingHistory` close bugs mentioned in
163
131
    sourcepackagerelease = source_publication.sourcepackagerelease
164
132
    changesfile_object = sourcepackagerelease.upload_changesfile
165
133
 
 
134
    # No changesfile available, cannot close bugs.
 
135
    if changesfile_object is None:
 
136
        return
 
137
 
166
138
    close_bugs_for_sourcepackagerelease(
167
 
        sourcepackagerelease, changesfile_object, since_version,
168
 
        upload_distroseries=source_publication.distroseries)
169
 
 
170
 
 
171
 
def close_bugs_for_sourcepackagerelease(source_release, changesfile_object,
172
 
                                        since_version=None,
173
 
                                        upload_distroseries=None):
 
139
        sourcepackagerelease, changesfile_object)
 
140
 
 
141
 
 
142
def close_bugs_for_sourcepackagerelease(source_release, changesfile_object):
174
143
    """Close bugs for a given source.
175
144
 
176
145
    Given a `ISourcePackageRelease` and a corresponding changesfile object,
177
146
    close bugs mentioned in the changesfile in the context of the source.
178
 
 
179
 
    If changesfile_object is None and since_version is supplied,
180
 
    close all the bugs in changelog entries made after that version and up
181
 
    to and including the source_release's version.  It does this by parsing
182
 
    the changelog on the sourcepackagerelease.  This could be extended in
183
 
    the future to deal with the changes file as well but there is no
184
 
    requirement to do so right now.
185
147
    """
186
 
    if since_version and source_release.changelog:
187
 
        bugs_to_close = get_bugs_from_changelog_entry(
188
 
            source_release, since_version=since_version)
189
 
    elif changesfile_object:
190
 
        bugs_to_close = get_bugs_from_changes_file(changesfile_object)
191
 
    else:
192
 
        return
 
148
    bugs_to_close = get_bugs_from_changes_file(changesfile_object)
193
149
 
194
150
    # No bugs to be closed by this upload, move on.
195
151
    if not bugs_to_close:
205
161
        # here, BE CAREFUL with the unproxied bug object and look at
206
162
        # what you're doing with it that might violate security.
207
163
        bug = removeSecurityProxy(bug)
208
 
        if upload_distroseries is not None:
209
 
            target = upload_distroseries.getSourcePackage(
210
 
                source_release.sourcepackagename)
211
 
        else:
212
 
            target = source_release.sourcepackage
213
164
        edited_task = bug.setStatus(
214
 
            target=target, status=BugTaskStatus.FIXRELEASED, user=janitor)
 
165
            target=source_release.sourcepackage,
 
166
            status=BugTaskStatus.FIXRELEASED,
 
167
            user=janitor)
215
168
        if edited_task is not None:
216
169
            assert source_release.changelog_entry is not None, (
217
170
                "New source uploads should have a changelog.")