~launchpad-pqm/launchpad/devel

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
# Copyright 2010 Canonical Ltd.  This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).

"""Test NascentUploadFile functionality."""

__metaclass__ = type

import hashlib
import os

from debian.deb822 import (
    Changes,
    Dsc,
    )

from canonical.testing.layers import LaunchpadZopelessLayer
from lp.archiveuploader.changesfile import ChangesFile
from lp.archiveuploader.dscfile import DSCFile
from lp.archiveuploader.nascentuploadfile import (
    CustomUploadFile,
    DebBinaryUploadFile,
    UploadError,
    )
from lp.registry.interfaces.pocket import PackagePublishingPocket
from lp.archiveuploader.tests import AbsolutelyAnythingGoesUploadPolicy
from lp.buildmaster.enums import BuildStatus
from lp.services.log.logger import BufferLogger
from lp.soyuz.enums import (
    PackageUploadCustomFormat,
    PackagePublishingStatus,
    )
from lp.testing import TestCaseWithFactory


class NascentUploadFileTestCase(TestCaseWithFactory):
    """Base class for all tests of classes deriving from NascentUploadFile."""

    def setUp(self):
        super(NascentUploadFileTestCase, self).setUp()
        self.logger = BufferLogger()
        self.policy = AbsolutelyAnythingGoesUploadPolicy()
        self.distro = self.factory.makeDistribution()
        self.policy.pocket = PackagePublishingPocket.RELEASE
        self.policy.archive = self.factory.makeArchive(
            distribution=self.distro)

    def writeUploadFile(self, filename, contents):
        """Write a temporary file but with a specific filename.

        :param filename: Filename to use
        :param contents: Contents of the file
        :return: Tuple with path, digest and size
        """
        path = os.path.join(self.makeTemporaryDirectory(), filename)
        f = open(path, 'w')
        try:
            f.write(contents)
        finally:
            f.close()
        return (path, hashlib.sha1(contents), len(contents))


class CustomUploadFileTests(NascentUploadFileTestCase):
    """Tests for CustomUploadFile."""

    layer = LaunchpadZopelessLayer

    def createCustomUploadFile(self, filename, contents,
                               component_and_section, priority_name):
        """Simple wrapper to create a CustomUploadFile."""
        (path, digest, size) = self.writeUploadFile(filename, contents)
        uploadfile = CustomUploadFile(
            path, digest, size, component_and_section, priority_name,
            self.policy, self.logger)
        return uploadfile

    def test_custom_type(self):
        # The mime type gets set according to PackageUploadCustomFormat.
        uploadfile = self.createCustomUploadFile(
            "bla.txt", "data", "main/raw-installer", "extra")
        self.assertEquals(
            PackageUploadCustomFormat.DEBIAN_INSTALLER,
            uploadfile.custom_type)

    def test_storeInDatabase(self):
        # storeInDatabase creates a library file.
        uploadfile = self.createCustomUploadFile(
            "bla.txt", "data", "main/raw-installer", "extra")
        self.assertEquals("application/octet-stream", uploadfile.content_type)
        libraryfile = uploadfile.storeInDatabase()
        self.assertEquals("bla.txt", libraryfile.filename)
        self.assertEquals("application/octet-stream", libraryfile.mimetype)


class PackageUploadFileTestCase(NascentUploadFileTestCase):
    """Base class for all tests of classes deriving from PackageUploadFile."""

    def setUp(self):
        super(PackageUploadFileTestCase, self).setUp()
        self.policy.distroseries = self.factory.makeDistroSeries(
            distribution=self.distro)

    def getBaseChanges(self):
        contents = Changes()
        contents["Source"] = "mypkg"
        contents["Binary"] = "binary"
        contents["Architecture"] = "i386"
        contents["Version"] = "0.1"
        contents["Distribution"] = "nifty"
        contents["Description"] = "\n Foo"
        contents["Maintainer"] = "Somebody"
        contents["Changes"] = "Something changed"
        contents["Date"] = "Fri, 25 Jun 2010 11:20:22 -0600"
        contents["Urgency"] = "low"
        contents["Changed-By"] = "Seombody Else <somebody@example.com>"
        contents["Files"] = [{
            "md5sum": "d2bd347b3fed184fe28e112695be491c",
            "size": "1791",
            "section": "python",
            "priority": "optional",
            "name": "dulwich_0.4.1-1.dsc"}]
        return contents

    def createChangesFile(self, filename, changes):
        tempdir = self.makeTemporaryDirectory()
        path = os.path.join(tempdir, filename)
        changes_fd = open(path, "w")
        try:
            changes.dump(changes_fd)
        finally:
            changes_fd.close()
        return ChangesFile(path, self.policy, self.logger)


class DSCFileTests(PackageUploadFileTestCase):
    """Tests for DSCFile."""

    layer = LaunchpadZopelessLayer

    def getBaseDsc(self):
        dsc = Dsc()
        dsc["Architecture"] = "all"
        dsc["Version"] = "0.42"
        dsc["Source"] = "dulwich"
        dsc["Binary"] = "python-dulwich"
        dsc["Standards-Version"] = "0.2.2"
        dsc["Maintainer"] = "Jelmer Vernooij <jelmer@ubuntu.com>"
        dsc["Files"] = [{
            "md5sum": "5e8ba79b4074e2f305ddeaf2543afe83",
            "size": "182280",
            "name": "dulwich_0.42.tar.gz"}]
        return dsc

    def createDSCFile(self, filename, dsc, component_and_section,
                      priority_name, package, version, changes):
        (path, digest, size) = self.writeUploadFile(filename, dsc.dump())
        if changes:
            self.assertEquals([], list(changes.processAddresses()))
        return DSCFile(
            path, digest, size, component_and_section, priority_name, package,
            version, changes, self.policy, self.logger)

    def test_filetype(self):
        # The filetype attribute is set based on the file extension.
        dsc = self.getBaseDsc()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42", None)
        self.assertEquals(
            "text/x-debian-source-package", uploadfile.content_type)

    def test_storeInDatabase(self):
        # storeInDatabase creates a SourcePackageRelease.
        dsc = self.getBaseDsc()
        dsc["Build-Depends"] = "dpkg, bzr"
        changes = self.getBaseChanges()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", changes))
        uploadfile.changelog = "DUMMY"
        uploadfile.files = []
        release = uploadfile.storeInDatabase(None)
        self.assertEquals("0.42", release.version)
        self.assertEquals("dpkg, bzr", release.builddepends)

    def test_storeInDatabase_case_sensitivity(self):
        # storeInDatabase supports field names with different cases,
        # confirming to Debian policy.
        dsc = self.getBaseDsc()
        dsc["buIld-depends"] = "dpkg, bzr"
        changes = self.getBaseChanges()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", changes))
        uploadfile.files = []
        uploadfile.changelog = "DUMMY"
        release = uploadfile.storeInDatabase(None)
        self.assertEquals("dpkg, bzr", release.builddepends)

    def test_user_defined_fields(self):
        # storeInDatabase updates user_defined_fields.
        dsc = self.getBaseDsc()
        dsc["Python-Version"] = "2.5"
        changes = self.getBaseChanges()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", changes))
        uploadfile.changelog = "DUMMY"
        uploadfile.files = []
        release = uploadfile.storeInDatabase(None)
        # DSCFile lowercases the field names
        self.assertEquals(
            [["Python-Version", u"2.5"]], release.user_defined_fields)

    def test_homepage(self):
        # storeInDatabase updates homepage.
        dsc = self.getBaseDsc()
        dsc["Homepage"] = "http://samba.org/~jelmer/bzr"
        changes = self.getBaseChanges()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", changes))
        uploadfile.changelog = "DUMMY"
        uploadfile.files = []
        release = uploadfile.storeInDatabase(None)
        self.assertEquals(u"http://samba.org/~jelmer/bzr", release.homepage)

    def test_checkBuild(self):
        # checkBuild() verifies consistency with a build.
        build = self.factory.makeSourcePackageRecipeBuild(
            pocket=self.policy.pocket, distroseries=self.policy.distroseries,
            archive=self.policy.archive)
        dsc = self.getBaseDsc()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", self.getBaseChanges()))
        uploadfile.checkBuild(build)
        # checkBuild() sets the build status to FULLYBUILT and
        # removes the upload log.
        self.assertEquals(BuildStatus.FULLYBUILT, build.status)
        self.assertIs(None, build.upload_log)

    def test_checkBuild_inconsistent(self):
        # checkBuild() raises UploadError if inconsistencies between build
        # and upload file are found.
        build = self.factory.makeSourcePackageRecipeBuild(
            pocket=self.policy.pocket,
            distroseries=self.factory.makeDistroSeries(),
            archive=self.policy.archive)
        dsc = self.getBaseDsc()
        uploadfile = self.createDSCFile(
            "foo.dsc", dsc, "main/net", "extra", "dulwich", "0.42",
            self.createChangesFile("foo.changes", self.getBaseChanges()))
        self.assertRaises(UploadError, uploadfile.checkBuild, build)


class DebBinaryUploadFileTests(PackageUploadFileTestCase):
    """Tests for DebBinaryUploadFile."""

    layer = LaunchpadZopelessLayer

    def getBaseControl(self):
        return {
            "Package": "python-dulwich",
            "Source": "dulwich",
            "Version": "0.42",
            "Architecture": "i386",
            "Maintainer": "Jelmer Vernooij <jelmer@debian.org>",
            "Installed-Size": "524",
            "Depends": "python (<< 2.7), python (>= 2.5)",
            "Provides": "python2.5-dulwich, python2.6-dulwich",
            "Section": "python",
            "Priority": "optional",
            "Homepage": "http://samba.org/~jelmer/dulwich",
            "Description": "Pure-python Git library\n"
                "Dulwich is a Python implementation of the file formats and "
                "protocols",
            }

    def createDebBinaryUploadFile(self, filename, component_and_section,
                                  priority_name, package, version, changes):
        """Create a DebBinaryUploadFile."""
        (path, digest, size) = self.writeUploadFile(filename, "DUMMY DATA")
        return DebBinaryUploadFile(
            path, digest, size, component_and_section, priority_name, package,
            version, changes, self.policy, self.logger)

    def test_unknown_priority(self):
        # Unknown priorities automatically get changed to 'extra'.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/net", "unknown", "mypkg", "0.42", None)
        self.assertEquals("extra", uploadfile.priority_name)

    def test_parseControl(self):
        # parseControl sets various fields on DebBinaryUploadFile.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        uploadfile.parseControl(control)
        self.assertEquals("python", uploadfile.section_name)
        self.assertEquals("dulwich", uploadfile.source_name)
        self.assertEquals("0.42", uploadfile.source_version)
        self.assertEquals("0.42", uploadfile.control_version)

    def test_storeInDatabase(self):
        # storeInDatabase creates a BinaryPackageRelease.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        uploadfile.parseControl(control)
        build = self.factory.makeBinaryPackageBuild()
        bpr = uploadfile.storeInDatabase(build)
        self.assertEquals(u'python (<< 2.7), python (>= 2.5)', bpr.depends)
        self.assertEquals(
            u"Dulwich is a Python implementation of the file formats "
            u"and protocols", bpr.description)
        self.assertEquals(False, bpr.essential)
        self.assertEquals(524, bpr.installedsize)
        self.assertEquals(True, bpr.architecturespecific)
        self.assertEquals(u"", bpr.recommends)
        self.assertEquals("0.42", bpr.version)

    def test_user_defined_fields(self):
        # storeInDatabase stores user defined fields.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        control["Python-Version"] = "2.5"
        uploadfile.parseControl(control)
        build = self.factory.makeBinaryPackageBuild()
        bpr = uploadfile.storeInDatabase(build)
        self.assertEquals(
            [[u"Python-Version", u"2.5"]], bpr.user_defined_fields)

    def test_user_defined_fields_newlines(self):
        # storeInDatabase stores user defined fields and keeps newlines.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        control["RandomData"] = "Foo\nbar\nbla\n"
        uploadfile.parseControl(control)
        build = self.factory.makeBinaryPackageBuild()
        bpr = uploadfile.storeInDatabase(build)
        self.assertEquals(
            [
                [u"RandomData", u"Foo\nbar\nbla\n"],
            ], bpr.user_defined_fields)

    def test_homepage(self):
        # storeInDatabase stores homepage field.
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        control["Python-Version"] = "2.5"
        uploadfile.parseControl(control)
        build = self.factory.makeBinaryPackageBuild()
        bpr = uploadfile.storeInDatabase(build)
        self.assertEquals(
            u"http://samba.org/~jelmer/dulwich", bpr.homepage)

    def test_checkBuild(self):
        # checkBuild() verifies consistency with a build.
        das = self.factory.makeDistroArchSeries(
            distroseries=self.policy.distroseries, architecturetag="i386")
        build = self.factory.makeBinaryPackageBuild(
            distroarchseries=das,
            archive=self.policy.archive)
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        uploadfile.checkBuild(build)
        # checkBuild() sets the build status to FULLYBUILT and
        # removes the upload log.
        self.assertEquals(BuildStatus.FULLYBUILT, build.status)
        self.assertIs(None, build.upload_log)

    def test_checkBuild_inconsistent(self):
        # checkBuild() raises UploadError if inconsistencies between build
        # and upload file are found.
        das = self.factory.makeDistroArchSeries(
            distroseries=self.policy.distroseries, architecturetag="amd64")
        build = self.factory.makeBinaryPackageBuild(
            distroarchseries=das,
            archive=self.policy.archive)
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        self.assertRaises(UploadError, uploadfile.checkBuild, build)

    def test_findSourcePackageRelease(self):
        # findSourcePackageRelease finds the matching SourcePackageRelease.
        das = self.factory.makeDistroArchSeries(
            distroseries=self.policy.distroseries, architecturetag="i386")
        build = self.factory.makeBinaryPackageBuild(
            distroarchseries=das,
            archive=self.policy.archive)
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        spph = self.factory.makeSourcePackagePublishingHistory(
            sourcepackagename=self.factory.makeSourcePackageName("foo"),
            distroseries=self.policy.distroseries,
            version="0.42", archive=self.policy.archive)
        control = self.getBaseControl()
        control["Source"] = "foo"
        uploadfile.parseControl(control)
        self.assertEquals(
            spph.sourcepackagerelease, uploadfile.findSourcePackageRelease())

    def test_findSourcePackageRelease_no_spph(self):
        # findSourcePackageRelease raises UploadError if there is no
        # SourcePackageRelease.
        das = self.factory.makeDistroArchSeries(
            distroseries=self.policy.distroseries, architecturetag="i386")
        build = self.factory.makeBinaryPackageBuild(
            distroarchseries=das,
            archive=self.policy.archive)
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        control = self.getBaseControl()
        control["Source"] = "foo"
        uploadfile.parseControl(control)
        self.assertRaises(UploadError, uploadfile.findSourcePackageRelease)

    def test_findSourcePackageRelease_multiple_sprs(self):
        # findSourcePackageRelease finds the last uploaded
        # SourcePackageRelease and can deal with multiple pending source
        # package releases.
        das = self.factory.makeDistroArchSeries(
            distroseries=self.policy.distroseries, architecturetag="i386")
        build = self.factory.makeBinaryPackageBuild(
            distroarchseries=das,
            archive=self.policy.archive)
        uploadfile = self.createDebBinaryUploadFile(
            "foo_0.42_i386.deb", "main/python", "unknown", "mypkg", "0.42",
            None)
        spn = self.factory.makeSourcePackageName("foo")
        spph1 = self.factory.makeSourcePackagePublishingHistory(
            sourcepackagename=spn,
            distroseries=self.policy.distroseries,
            version="0.42", archive=self.policy.archive,
            status=PackagePublishingStatus.PUBLISHED)
        spph2 = self.factory.makeSourcePackagePublishingHistory(
            sourcepackagename=spn,
            distroseries=self.policy.distroseries,
            version="0.42", archive=self.policy.archive,
            status=PackagePublishingStatus.PENDING)
        control = self.getBaseControl()
        control["Source"] = "foo"
        uploadfile.parseControl(control)
        self.assertEquals(
            spph2.sourcepackagerelease, uploadfile.findSourcePackageRelease())