1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
# Copyright 2010 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Unit tests for Specification."""
__metaclass__ = type
from zope.component import getUtility
from zope.security.interfaces import Unauthorized
from zope.security.proxy import removeSecurityProxy
from canonical.launchpad.webapp.authorization import check_permission
from canonical.testing.layers import DatabaseFunctionalLayer
from lp.blueprints.errors import TargetAlreadyHasSpecification
from lp.blueprints.enums import (
NewSpecificationDefinitionStatus,
SpecificationDefinitionStatus,
SpecificationGoalStatus,
)
from lp.blueprints.interfaces.specification import ISpecificationSet
from lp.testing import (
login_person,
TestCaseWithFactory,
)
class SpecificationTests(TestCaseWithFactory):
layer = DatabaseFunctionalLayer
def test_target_driver_has_edit_rights(self):
"""Drivers of a blueprint's target can edit that blueprint."""
product = self.factory.makeProduct()
driver = self.factory.makePerson()
removeSecurityProxy(product).driver = driver
specification = self.factory.makeSpecification(product=product)
login_person(driver)
self.assertTrue(check_permission('launchpad.Edit', specification))
def test_auto_accept_of_goal_for_drivers(self):
"""Drivers of a series accept the goal when they propose."""
product = self.factory.makeProduct()
proposer = self.factory.makePerson()
productseries = self.factory.makeProductSeries(product=product)
removeSecurityProxy(productseries).driver = proposer
specification = self.factory.makeSpecification(product=product)
specification.proposeGoal(productseries, proposer)
self.assertEqual(
SpecificationGoalStatus.ACCEPTED, specification.goalstatus)
def test_goal_not_accepted_for_non_drivers(self):
"""People who aren't drivers don't have their proposals approved."""
product = self.factory.makeProduct()
proposer = self.factory.makePerson()
productseries = self.factory.makeProductSeries(product=product)
specification = self.factory.makeSpecification(product=product)
specification.proposeGoal(productseries, proposer)
self.assertEqual(
SpecificationGoalStatus.PROPOSED, specification.goalstatus)
def test_retarget_existing_specification(self):
"""An error is raised if the name is already taken."""
product1 = self.factory.makeProduct()
product2 = self.factory.makeProduct()
specification1 = self.factory.makeSpecification(
product=product1, name="foo")
specification2 = self.factory.makeSpecification(
product=product2, name="foo")
self.assertRaises(
TargetAlreadyHasSpecification,
removeSecurityProxy(specification1).retarget, product2)
def test_retarget_is_protected(self):
specification = self.factory.makeSpecification(
product=self.factory.makeProduct())
self.assertRaises(
Unauthorized, getattr, specification, 'retarget')
def test_validate_move_existing_specification(self):
"""An error is raised by validateMove if the name is already taken."""
product1 = self.factory.makeProduct()
product2 = self.factory.makeProduct()
specification1 = self.factory.makeSpecification(
product=product1, name="foo")
specification2 = self.factory.makeSpecification(
product=product2, name="foo")
self.assertRaises(
TargetAlreadyHasSpecification, specification1.validateMove,
product2)
def test_setTarget(self):
product = self.factory.makeProduct()
specification = self.factory.makeSpecification(product=product)
self.assertEqual(product, specification.target)
self.assertIs(None, specification.distribution)
distribution = self.factory.makeDistribution()
removeSecurityProxy(specification).setTarget(distribution)
self.assertEqual(distribution, specification.target)
self.assertEqual(distribution, specification.distribution)
self.assertIs(None, specification.product)
def test_setTarget_is_protected(self):
specification = self.factory.makeSpecification(
product=self.factory.makeProduct())
self.assertRaises(
Unauthorized, getattr, specification, 'setTarget')
class TestSpecificationSet(TestCaseWithFactory):
layer = DatabaseFunctionalLayer
def setUp(self):
super(TestSpecificationSet, self).setUp()
self.specification_set = getUtility(ISpecificationSet)
self.new_names = NewSpecificationDefinitionStatus.items.mapping.keys()
def test_new_with_open_definition_status_creates_specification(self):
# Calling new() with an open definition status will will create
# a specification.
self.assertTrue(
SpecificationDefinitionStatus.NEW.name in self.new_names)
product = self.factory.makeProduct()
spec = self.specification_set.new(
name='plane', title='Place', specurl='http://eg.org/plane',
summary='summary', owner=product.owner, product=product,
definition_status=SpecificationDefinitionStatus.NEW)
self.assertEqual(
SpecificationDefinitionStatus.NEW, spec.definition_status)
def test_new_with_closed_definition_status_raises_error(self):
# Calling new() with a obsolete or superseded definition status
# raises an error.
self.assertTrue(
SpecificationDefinitionStatus.OBSOLETE.name not in self.new_names)
product = self.factory.makeProduct()
args = dict(
name='plane', title='Place', specurl='http://eg.org/plane',
summary='summary', owner=product.owner, product=product,
definition_status=SpecificationDefinitionStatus.OBSOLETE)
self.assertRaises(
AssertionError, self.specification_set.new, **args)
|