1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
|
# Copyright 2010-2011 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Tests for `IPackageBuild`."""
__metaclass__ = type
from datetime import datetime
import hashlib
import os
import shutil
import tempfile
from storm.store import Store
from zope.component import getUtility
from zope.security.interfaces import Unauthorized
from zope.security.proxy import removeSecurityProxy
from canonical.config import config
from canonical.database.constants import UTC_NOW
from canonical.testing.layers import (
LaunchpadFunctionalLayer,
LaunchpadZopelessLayer,
)
from lp.archiveuploader.uploadprocessor import parse_build_upload_leaf_name
from lp.buildmaster.enums import (
BuildFarmJobType,
BuildStatus,
)
from lp.buildmaster.interfaces.packagebuild import (
IPackageBuild,
IPackageBuildSet,
IPackageBuildSource,
)
from lp.buildmaster.model.builder import BuilderSlave
from lp.buildmaster.model.buildfarmjob import BuildFarmJob
from lp.buildmaster.model.packagebuild import PackageBuild
from lp.buildmaster.tests.mock_slaves import WaitingSlave
from lp.registry.interfaces.pocket import PackagePublishingPocket
from lp.testing import (
login,
login_person,
TestCaseWithFactory,
)
from lp.testing.factory import LaunchpadObjectFactory
from lp.testing.fakemethod import FakeMethod
from lp.testing.mail_helpers import pop_notifications
class TestPackageBuildBase(TestCaseWithFactory):
"""Provide a factory method for creating PackageBuilds.
This is not included in the launchpad test factory because
only classes deriving from PackageBuild should be used.
"""
def makePackageBuild(
self, archive=None, job_type=BuildFarmJobType.PACKAGEBUILD,
status=BuildStatus.NEEDSBUILD,
pocket=PackagePublishingPocket.RELEASE):
if archive is None:
archive = self.factory.makeArchive()
return getUtility(IPackageBuildSource).new(
job_type=job_type, virtualized=True, archive=archive,
status=status, pocket=pocket)
class TestPackageBuild(TestPackageBuildBase):
"""Tests for the package build object."""
layer = LaunchpadFunctionalLayer
def setUp(self):
"""Create a package build with which to test."""
super(TestPackageBuild, self).setUp()
joe = self.factory.makePerson(name="joe")
joes_ppa = self.factory.makeArchive(owner=joe, name="ppa")
self.package_build = self.makePackageBuild(archive=joes_ppa)
def test_providesInterface(self):
# PackageBuild provides IPackageBuild
self.assertProvides(self.package_build, IPackageBuild)
def test_saves_record(self):
# A package build can be stored in the database.
store = Store.of(self.package_build)
store.flush()
retrieved_build = store.find(
PackageBuild,
PackageBuild.id == self.package_build.id).one()
self.assertEqual(self.package_build, retrieved_build)
def test_unimplemented_methods(self):
# Classes deriving from PackageBuild must provide getTitle.
self.assertRaises(NotImplementedError, self.package_build.getTitle)
self.assertRaises(
NotImplementedError, self.package_build.estimateDuration)
self.assertRaises(
NotImplementedError, self.package_build.verifySuccessfulUpload)
self.assertRaises(NotImplementedError, self.package_build.notify)
self.assertRaises(
NotImplementedError, self.package_build.handleStatus,
None, None, None)
def test_default_values(self):
# PackageBuild has a number of default values.
self.failUnlessEqual(
'multiverse', self.package_build.current_component.name)
self.failUnlessEqual(None, self.package_build.distribution)
self.failUnlessEqual(None, self.package_build.distro_series)
def test_log_url(self):
# The url of the build log file is determined by the PackageBuild.
lfa = self.factory.makeLibraryFileAlias('mybuildlog.txt')
removeSecurityProxy(self.package_build).log = lfa
log_url = self.package_build.log_url
self.failUnlessEqual(
'http://launchpad.dev/~joe/'
'+archive/ppa/+build/%d/+files/mybuildlog.txt' % (
self.package_build.build_farm_job.id),
log_url)
def test_storeUploadLog(self):
# The given content is uploaded to the librarian and linked as
# the upload log.
self.package_build.storeUploadLog("Some content")
self.failIfEqual(None, self.package_build.upload_log)
self.failUnlessEqual(
hashlib.sha1("Some content").hexdigest(),
self.package_build.upload_log.content.sha1)
def test_storeUploadLog_private(self):
# A private package build will store the upload log on the
# restricted librarian.
login('admin@canonical.com')
self.package_build.archive.buildd_secret = 'sekrit'
self.package_build.archive.private = True
self.failUnless(self.package_build.is_private)
self.package_build.storeUploadLog("Some content")
self.failUnless(self.package_build.upload_log.restricted)
def test_storeUploadLog_unicode(self):
# Unicode upload logs are uploaded as UTF-8.
unicode_content = u"Some content \N{SNOWMAN}"
self.package_build.storeUploadLog(unicode_content)
self.failIfEqual(None, self.package_build.upload_log)
self.failUnlessEqual(
hashlib.sha1(unicode_content.encode('utf-8')).hexdigest(),
self.package_build.upload_log.content.sha1)
def test_upload_log_url(self):
# The url of the upload log file is determined by the PackageBuild.
Store.of(self.package_build).flush()
build_id = self.package_build.build_farm_job.id
self.package_build.storeUploadLog("Some content")
log_url = self.package_build.upload_log_url
self.failUnlessEqual(
'http://launchpad.dev/~joe/'
'+archive/ppa/+build/%d/+files/upload_%d_log.txt' % (
build_id, build_id),
log_url)
def test_view_package_build(self):
# Anonymous access can read public builds, but not edit.
self.failUnlessEqual(
None, self.package_build.dependencies)
self.assertRaises(
Unauthorized, setattr, self.package_build,
'dependencies', u'my deps')
def test_edit_package_build(self):
# An authenticated user who belongs to the owning archive team
# can edit the build.
login_person(self.package_build.archive.owner)
self.package_build.dependencies = u'My deps'
self.failUnlessEqual(
u'My deps', self.package_build.dependencies)
# But other users cannot.
other_person = self.factory.makePerson()
login_person(other_person)
self.assertRaises(
Unauthorized, setattr, self.package_build,
'dependencies', u'my deps')
def test_admin_package_build(self):
# Users with edit access can update attributes.
login('admin@canonical.com')
self.package_build.dependencies = u'My deps'
self.failUnlessEqual(
u'My deps', self.package_build.dependencies)
def test_getUploadDirLeaf(self):
# getUploadDirLeaf returns the current time, followed by the build
# cookie.
now = datetime.now()
build_cookie = self.factory.getUniqueString()
upload_leaf = self.package_build.getUploadDirLeaf(
build_cookie, now=now)
self.assertEqual(
'%s-%s' % (now.strftime("%Y%m%d-%H%M%S"), build_cookie),
upload_leaf)
def test_destroySelf_removes_BuildFarmJob(self):
# Destroying a packagebuild also destroys the BuildFarmJob it
# references.
naked_build = removeSecurityProxy(self.package_build)
store = Store.of(self.package_build)
# Ensure build_farm_job_id is set.
store.flush()
build_farm_job_id = naked_build.build_farm_job_id
naked_build.destroySelf()
result = store.find(
BuildFarmJob, BuildFarmJob.id == build_farm_job_id)
self.assertIs(None, result.one())
class TestPackageBuildSet(TestPackageBuildBase):
layer = LaunchpadFunctionalLayer
def setUp(self):
super(TestPackageBuildSet, self).setUp()
person = self.factory.makePerson()
self.archive = self.factory.makeArchive(owner=person)
self.package_builds = []
self.package_builds.append(
self.makePackageBuild(archive=self.archive,
pocket=PackagePublishingPocket.UPDATES))
self.package_builds.append(
self.makePackageBuild(archive=self.archive,
status=BuildStatus.BUILDING))
self.package_build_set = getUtility(IPackageBuildSet)
def test_getBuildsForArchive_all(self):
# The default call without arguments returns all builds for the
# archive.
self.assertContentEqual(
self.package_builds, self.package_build_set.getBuildsForArchive(
self.archive))
def test_getBuildsForArchive_by_status(self):
# If the status arg is used, the results will be filtered by
# status.
self.assertContentEqual(
self.package_builds[1:],
self.package_build_set.getBuildsForArchive(
self.archive, status=BuildStatus.BUILDING))
def test_getBuildsForArchive_by_pocket(self):
# If the pocket arg is used, the results will be filtered by
# pocket.
self.assertContentEqual(
self.package_builds[:1],
self.package_build_set.getBuildsForArchive(
self.archive, pocket=PackagePublishingPocket.UPDATES))
class TestGetUploadMethodsMixin:
"""Tests for `IPackageBuild` that need objects from the rest of LP."""
layer = LaunchpadZopelessLayer
def makeBuild(self):
"""Allow classes to override the build with which the test runs."""
raise NotImplemented
def setUp(self):
super(TestGetUploadMethodsMixin, self).setUp()
self.build = self.makeBuild()
def test_getUploadDirLeafCookie_parseable(self):
# getUploadDirLeaf should return a directory name
# that is parseable by the upload processor.
upload_leaf = self.build.getUploadDirLeaf(
self.build.getBuildCookie())
(job_type, job_id) = parse_build_upload_leaf_name(upload_leaf)
self.assertEqual(
(self.build.build_farm_job.job_type.name, self.build.id),
(job_type, job_id))
class TestHandleStatusMixin:
"""Tests for `IPackageBuild`s handleStatus method."""
layer = LaunchpadZopelessLayer
def makeBuild(self):
"""Allow classes to override the build with which the test runs."""
raise NotImplementedError
def setUp(self):
super(TestHandleStatusMixin, self).setUp()
self.factory = LaunchpadObjectFactory()
self.build = self.makeBuild()
# For the moment, we require a builder for the build so that
# handleStatus_OK can get a reference to the slave.
builder = self.factory.makeBuilder()
self.build.buildqueue_record.builder = builder
self.build.buildqueue_record.setDateStarted(UTC_NOW)
self.slave = WaitingSlave('BuildStatus.OK')
self.slave.valid_file_hashes.append('test_file_hash')
self.patch(BuilderSlave, 'makeBuilderSlave', FakeMethod(self.slave))
# We overwrite the buildmaster root to use a temp directory.
tempdir = tempfile.mkdtemp()
self.addCleanup(shutil.rmtree, tempdir)
self.upload_root = tempdir
tmp_builddmaster_root = """
[builddmaster]
root: %s
""" % self.upload_root
config.push('tmp_builddmaster_root', tmp_builddmaster_root)
# We stub out our builds getUploaderCommand() method so
# we can check whether it was called as well as
# verifySuccessfulUpload().
removeSecurityProxy(self.build).verifySuccessfulUpload = FakeMethod(
result=True)
def assertResultCount(self, count, result):
self.assertEquals(
1, len(os.listdir(os.path.join(self.upload_root, result))))
def test_handleStatus_OK_normal_file(self):
# A filemap with plain filenames should not cause a problem.
# The call to handleStatus will attempt to get the file from
# the slave resulting in a URL error in this test case.
def got_status(ignored):
self.assertEqual(BuildStatus.UPLOADING, self.build.status)
self.assertResultCount(1, "incoming")
d = self.build.handleStatus('OK', None, {
'filemap': {'myfile.py': 'test_file_hash'},
})
return d.addCallback(got_status)
def test_handleStatus_OK_absolute_filepath(self):
# A filemap that tries to write to files outside of
# the upload directory will result in a failed upload.
def got_status(ignored):
self.assertEqual(BuildStatus.FAILEDTOUPLOAD, self.build.status)
self.assertResultCount(0, "failed")
self.assertIs(None, self.build.buildqueue_record)
d = self.build.handleStatus('OK', None, {
'filemap': {'/tmp/myfile.py': 'test_file_hash'},
})
return d.addCallback(got_status)
def test_handleStatus_OK_relative_filepath(self):
# A filemap that tries to write to files outside of
# the upload directory will result in a failed upload.
def got_status(ignored):
self.assertEqual(BuildStatus.FAILEDTOUPLOAD, self.build.status)
self.assertResultCount(0, "failed")
d = self.build.handleStatus('OK', None, {
'filemap': {'../myfile.py': 'test_file_hash'},
})
return d.addCallback(got_status)
def test_handleStatus_OK_sets_build_log(self):
# The build log is set during handleStatus.
removeSecurityProxy(self.build).log = None
self.assertEqual(None, self.build.log)
d = self.build.handleStatus('OK', None, {
'filemap': {'myfile.py': 'test_file_hash'},
})
def got_status(ignored):
self.assertNotEqual(None, self.build.log)
return d.addCallback(got_status)
def _test_handleStatus_notifies(self, status):
# An email notification is sent for a given build status if
# notifications are allowed for that status.
naked_build = removeSecurityProxy(self.build)
expected_notification = (
status in naked_build.ALLOWED_STATUS_NOTIFICATIONS)
def got_status(ignored):
if expected_notification:
self.assertNotEqual(
0, len(pop_notifications()), "No notifications received.")
else:
self.assertContentEqual([], pop_notifications())
d = self.build.handleStatus(status, None, {})
return d.addCallback(got_status)
def test_handleStatus_DEPFAIL_notifies(self):
return self._test_handleStatus_notifies("DEPFAIL")
def test_handleStatus_CHROOTFAIL_notifies(self):
return self._test_handleStatus_notifies("CHROOTFAIL")
def test_handleStatus_PACKAGEFAIL_notifies(self):
return self._test_handleStatus_notifies("PACKAGEFAIL")
def test_date_finished_set(self):
# The date finished is updated during handleStatus_OK.
removeSecurityProxy(self.build).date_finished = None
self.assertEqual(None, self.build.date_finished)
d = self.build.handleStatus('OK', None, {
'filemap': {'myfile.py': 'test_file_hash'},
})
def got_status(ignored):
self.assertNotEqual(None, self.build.date_finished)
return d.addCallback(got_status)
|