1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
# Copyright 2011 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Tests for BugTaskSet."""
__metaclass__ = type
from zope.component import getUtility
from lp.bugs.interfaces.bugtask import (
BugTaskStatus,
BugTaskStatusSearch,
IBugTaskSet,
)
from lp.services.database.sqlbase import flush_database_updates
from lp.testing import (
login_person,
TestCaseWithFactory,
)
from lp.testing.layers import DatabaseFunctionalLayer
class TestStatusCountsForProductSeries(TestCaseWithFactory):
"""Test BugTaskSet.getStatusCountsForProductSeries()."""
layer = DatabaseFunctionalLayer
def setUp(self):
super(TestStatusCountsForProductSeries, self).setUp()
self.bugtask_set = getUtility(IBugTaskSet)
self.owner = self.factory.makePerson()
login_person(self.owner)
self.product = self.factory.makeProduct(owner=self.owner)
self.series = self.factory.makeProductSeries(product=self.product)
self.milestone = self.factory.makeMilestone(productseries=self.series)
def get_counts(self, user):
return self.bugtask_set.getStatusCountsForProductSeries(
user, self.series)
def test_privacy_and_counts_for_unauthenticated_user(self):
# An unauthenticated user should see bug counts for each status
# that do not include private bugs.
self.factory.makeBug(milestone=self.milestone)
self.factory.makeBug(milestone=self.milestone, private=True)
self.factory.makeBug(series=self.series)
self.factory.makeBug(series=self.series, private=True)
self.assertEqual(
{BugTaskStatus.NEW: 2},
self.get_counts(None))
def test_privacy_and_counts_for_owner(self):
# The owner should see bug counts for each status that do
# include all private bugs.
self.factory.makeBug(milestone=self.milestone)
self.factory.makeBug(milestone=self.milestone, private=True)
self.factory.makeBug(series=self.series)
self.factory.makeBug(series=self.series, private=True)
self.assertEqual(
{BugTaskStatus.NEW: 4},
self.get_counts(self.owner))
def test_privacy_and_counts_for_other_user(self):
# A random authenticated user should see bug counts for each
# status that do include all private bugs, since it is costly to
# query just the private bugs that the user has access to view,
# and this query may be run many times on a single page.
self.factory.makeBug(milestone=self.milestone)
self.factory.makeBug(milestone=self.milestone, private=True)
self.factory.makeBug(series=self.series)
self.factory.makeBug(series=self.series, private=True)
other = self.factory.makePerson()
self.assertEqual(
{BugTaskStatus.NEW: 4},
self.get_counts(other))
def test_multiple_statuses(self):
# Test that separate counts are provided for each status that
# bugs are found in.
statuses = [
BugTaskStatus.INVALID,
BugTaskStatus.OPINION,
]
for status in statuses:
self.factory.makeBug(milestone=self.milestone, status=status)
self.factory.makeBug(series=self.series, status=status)
for i in range(3):
self.factory.makeBug(series=self.series)
expected = {
BugTaskStatus.INVALID: 2,
BugTaskStatus.OPINION: 2,
BugTaskStatus.NEW: 3,
}
self.assertEqual(expected, self.get_counts(None))
def test_incomplete_status(self):
# INCOMPLETE is stored as either INCOMPLETE_WITH_RESPONSE or
# INCOMPLETE_WITHOUT_RESPONSE so the stats do not include a count of
# INCOMPLETE tasks.
statuses = [
BugTaskStatusSearch.INCOMPLETE_WITH_RESPONSE,
BugTaskStatusSearch.INCOMPLETE_WITHOUT_RESPONSE,
BugTaskStatus.INCOMPLETE,
]
for status in statuses:
self.factory.makeBug(series=self.series, status=status)
flush_database_updates()
expected = {
BugTaskStatusSearch.INCOMPLETE_WITH_RESPONSE: 1,
BugTaskStatusSearch.INCOMPLETE_WITHOUT_RESPONSE: 2,
}
self.assertEqual(expected, self.get_counts(None))
class TestBugTaskMilestones(TestCaseWithFactory):
"""Tests that appropriate milestones are returned for bugtasks."""
layer = DatabaseFunctionalLayer
def setUp(self):
super(TestBugTaskMilestones, self).setUp()
self.product = self.factory.makeProduct()
self.product_bug = self.factory.makeBug(product=self.product)
self.product_milestone = self.factory.makeMilestone(
product=self.product)
self.distribution = self.factory.makeDistribution()
self.distribution_bug = self.factory.makeBug(
distribution=self.distribution)
self.distribution_milestone = self.factory.makeMilestone(
distribution=self.distribution)
self.bugtaskset = getUtility(IBugTaskSet)
def test_get_target_milestones_with_one_task(self):
milestones = list(self.bugtaskset.getBugTaskTargetMilestones(
[self.product_bug.default_bugtask]))
self.assertEqual(
[self.product_milestone],
milestones)
def test_get_target_milestones_multiple_tasks(self):
tasks = [
self.product_bug.default_bugtask,
self.distribution_bug.default_bugtask,
]
milestones = sorted(
self.bugtaskset.getBugTaskTargetMilestones(tasks))
self.assertEqual(
sorted([self.product_milestone, self.distribution_milestone]),
milestones)
|