1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
|
# Copyright 2009 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Test the person_sort_key stored procedure."""
__metaclass__ = type
from zope.component import getUtility
from zope.interface.verify import verifyObject
from lp.app.interfaces.launchpad import ILaunchpadCelebrities
from lp.registry.interfaces.nameblacklist import (
INameBlacklist,
INameBlacklistSet,
)
from lp.services.database.lpstorm import IStore
from lp.services.webapp.authorization import check_permission
from lp.testing import (
ANONYMOUS,
login,
login_celebrity,
TestCaseWithFactory,
)
from lp.testing.layers import (
DatabaseFunctionalLayer,
ZopelessDatabaseLayer,
)
class TestNameBlacklist(TestCaseWithFactory):
layer = ZopelessDatabaseLayer
def setUp(self):
super(TestNameBlacklist, self).setUp()
self.name_blacklist_set = getUtility(INameBlacklistSet)
self.caret_foo_exp = self.name_blacklist_set.create(u'^foo')
self.foo_exp = self.name_blacklist_set.create(u'foo')
self.verbose_exp = self.name_blacklist_set.create(u'v e r b o s e')
team = self.factory.makeTeam()
self.admin_exp = self.name_blacklist_set.create(u'fnord', admin=team)
self.store = IStore(self.foo_exp)
self.store.flush()
def name_blacklist_match(self, name, user_id=None):
'''Return the result of the name_blacklist_match stored procedure.'''
user_id = user_id or 0
result = self.store.execute(
"SELECT name_blacklist_match(%s, %s)", (name, user_id))
return result.get_one()[0]
def is_blacklisted_name(self, name, user_id=None):
'''Call the is_blacklisted_name stored procedure and return the result
'''
user_id = user_id or 0
result = self.store.execute(
"SELECT is_blacklisted_name(%s, %s)", (name, user_id))
blacklisted = result.get_one()[0]
self.failIf(blacklisted is None, 'is_blacklisted_name returned NULL')
return bool(blacklisted)
def test_name_blacklist_match(self):
# A name that is not blacklisted returns NULL/None
self.failUnless(self.name_blacklist_match(u"bar") is None)
# A name that is blacklisted returns the id of the row in the
# NameBlacklist table that matched. Rows are tried in order, and the
# first match is returned.
self.assertEqual(
self.name_blacklist_match(u"foobar"),
self.caret_foo_exp.id)
self.assertEqual(
self.name_blacklist_match(u"barfoo"),
self.foo_exp.id)
def test_name_blacklist_match_admin_does_not_match(self):
# A user in the expresssion's admin team is exempt from the
# backlisted name restriction.
user = self.admin_exp.admin.teamowner
self.assertEqual(
None, self.name_blacklist_match(u"fnord", user.id))
def test_name_blacklist_match_launchpad_admin_can_change(self):
# A Launchpad admin is exempt from any backlisted name restriction
# that has an admin.
user = self.factory.makePerson()
admins = getUtility(ILaunchpadCelebrities).admin
admins.addMember(user, user)
self.assertEqual(
None, self.name_blacklist_match(u"fnord", user.id))
def test_name_blacklist_match_launchpad_admin_cannot_change(self):
# A Launchpad admin cannot override backlisted names without admins.
user = self.factory.makePerson()
admins = getUtility(ILaunchpadCelebrities).admin
admins.addMember(user, user)
self.assertEqual(
self.foo_exp.id, self.name_blacklist_match(u"barfoo", user.id))
def test_name_blacklist_match_cache(self):
# If the blacklist is changed in the DB, these changes are noticed.
# This test is needed because the stored procedure keeps a cache
# of the compiled regular expressions.
self.assertEqual(
self.name_blacklist_match(u"foobar"),
self.caret_foo_exp.id)
self.caret_foo_exp.regexp = u'nomatch'
self.assertEqual(
self.name_blacklist_match(u"foobar"),
self.foo_exp.id)
self.foo_exp.regexp = u'nomatch2'
self.failUnless(self.name_blacklist_match(u"foobar") is None)
def test_is_blacklisted_name(self):
# is_blacklisted_name() is just a wrapper around name_blacklist_match
# that is friendlier to use in a boolean context.
self.failUnless(self.is_blacklisted_name(u"bar") is False)
self.failUnless(self.is_blacklisted_name(u"foo") is True)
self.caret_foo_exp.regexp = u'bar'
self.foo_exp.regexp = u'bar2'
self.failUnless(self.is_blacklisted_name(u"foo") is False)
def test_is_blacklisted_name_admin_false(self):
# Users in the expression's admin team are will return False.
user = self.admin_exp.admin.teamowner
self.assertFalse(self.is_blacklisted_name(u"fnord", user.id))
def test_case_insensitive(self):
self.failUnless(self.is_blacklisted_name(u"Foo") is True)
def test_verbose(self):
# Testing the VERBOSE flag is used when compiling the regexp
self.failUnless(self.is_blacklisted_name(u"verbose") is True)
class TestNameBlacklistSet(TestCaseWithFactory):
layer = DatabaseFunctionalLayer
def setUp(self):
super(TestNameBlacklistSet, self).setUp()
login_celebrity('registry_experts')
self.name_blacklist_set = getUtility(INameBlacklistSet)
def test_create_with_one_arg(self):
# Test NameBlacklistSet.create(regexp).
name_blacklist = self.name_blacklist_set.create(u'foo')
self.assertTrue(verifyObject(INameBlacklist, name_blacklist))
self.assertEqual(u'foo', name_blacklist.regexp)
self.assertIs(None, name_blacklist.comment)
def test_create_with_two_args(self):
# Test NameBlacklistSet.create(regexp, comment).
name_blacklist = self.name_blacklist_set.create(u'foo', u'bar')
self.assertTrue(verifyObject(INameBlacklist, name_blacklist))
self.assertEqual(u'foo', name_blacklist.regexp)
self.assertEqual(u'bar', name_blacklist.comment)
def test_create_with_three_args(self):
# Test NameBlacklistSet.create(regexp, comment, admin).
team = self.factory.makeTeam()
name_blacklist = self.name_blacklist_set.create(u'foo', u'bar', team)
self.assertTrue(verifyObject(INameBlacklist, name_blacklist))
self.assertEqual(u'foo', name_blacklist.regexp)
self.assertEqual(u'bar', name_blacklist.comment)
self.assertEqual(team, name_blacklist.admin)
def test_get_int(self):
# Test NameBlacklistSet.get() with int id.
name_blacklist = self.name_blacklist_set.create(u'foo', u'bar')
store = IStore(name_blacklist)
store.flush()
retrieved = self.name_blacklist_set.get(name_blacklist.id)
self.assertEqual(name_blacklist, retrieved)
def test_get_string(self):
# Test NameBlacklistSet.get() with string id.
name_blacklist = self.name_blacklist_set.create(u'foo', u'bar')
store = IStore(name_blacklist)
store.flush()
retrieved = self.name_blacklist_set.get(str(name_blacklist.id))
self.assertEqual(name_blacklist, retrieved)
def test_get_returns_None_instead_of_ValueError(self):
# Test that NameBlacklistSet.get() will return None instead of
# raising a ValueError when it tries to cast the id to an int,
# so that traversing an invalid url causes a Not Found error
# instead of an error that is recorded as an oops.
self.assertIs(None, self.name_blacklist_set.get('asdf'))
def test_getAll(self):
# Test NameBlacklistSet.getAll().
result = [
(item.regexp, item.comment)
for item in self.name_blacklist_set.getAll()]
expected = [
('^admin', None),
('blacklist', 'For testing purposes'),
]
self.assertEqual(expected, result)
def test_NameBlacklistSet_permissions(self):
# Verify that non-registry-experts do not have permission to
# access the NameBlacklistSet.
self.assertTrue(
check_permission('launchpad.View', self.name_blacklist_set))
self.assertTrue(
check_permission('launchpad.Edit', self.name_blacklist_set))
login(ANONYMOUS)
self.assertFalse(
check_permission('launchpad.View', self.name_blacklist_set))
self.assertFalse(
check_permission('launchpad.Edit', self.name_blacklist_set))
def test_NameBlacklist_permissions(self):
# Verify that non-registry-experts do not have permission to
# access the NameBlacklist.
name_blacklist = self.name_blacklist_set.create(u'foo')
self.assertTrue(check_permission('launchpad.View', name_blacklist))
self.assertTrue(check_permission('launchpad.Edit', name_blacklist))
login(ANONYMOUS)
self.assertFalse(check_permission('launchpad.View', name_blacklist))
self.assertFalse(check_permission('launchpad.Edit', name_blacklist))
|