1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
|
# Copyright 2009 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Test harness for running tests agains IBugTarget implementations.
This module runs the interface test against the Product, ProductSeries
ProjectGroup, DistributionSourcePackage, and DistroSeries implementations
IBugTarget. It runs the bugtarget-questiontarget.txt test.
"""
# pylint: disable-msg=C0103
__metaclass__ = type
__all__ = []
import random
import unittest
from storm.expr import LeftJoin
from storm.store import Store
from testtools.matchers import Equals
from zope.component import getUtility
from lp.bugs.interfaces.bug import CreateBugParams
from lp.bugs.interfaces.bugtask import (
BugTaskSearchParams,
BugTaskStatus,
IBugTaskSet,
)
from lp.bugs.model.bugtask import BugTask
from lp.registry.interfaces.distribution import (
IDistribution,
IDistributionSet,
)
from lp.registry.interfaces.product import IProductSet
from lp.registry.interfaces.projectgroup import IProjectGroupSet
from lp.registry.model.milestone import Milestone
from lp.services.webapp.interfaces import ILaunchBag
from lp.testing import (
person_logged_in,
StormStatementRecorder,
TestCaseWithFactory,
)
from lp.testing.layers import DatabaseFunctionalLayer
from lp.testing.matchers import HasQueryCount
from lp.testing.systemdocs import (
LayeredDocFileSuite,
setUp,
tearDown,
)
def bugtarget_filebug(bugtarget, summary, status=None):
"""File a bug as the current user on the bug target and return it."""
return bugtarget.createBug(CreateBugParams(
getUtility(ILaunchBag).user, summary, comment=summary, status=status))
def productSetUp(test):
"""Setup the `IProduct` test."""
setUp(test)
test.globs['bugtarget'] = getUtility(IProductSet).getByName('firefox')
test.globs['filebug'] = bugtarget_filebug
test.globs['question_target'] = test.globs['bugtarget']
def project_filebug(project, summary, status=None):
"""File a bug on a project.
Since it's not possible to file a bug on a project directly, the bug
will be filed on one of its products.
"""
# It doesn't matter which product the bug is filed on.
product = random.choice(list(project.products))
bug = bugtarget_filebug(product, summary, status=status)
return bug
def projectSetUp(test):
"""Setup the `IProjectGroup` test."""
setUp(test)
projectgroups = getUtility(IProjectGroupSet)
test.globs['bugtarget'] = projectgroups.getByName('mozilla')
test.globs['filebug'] = project_filebug
def productseries_filebug(productseries, summary, status=None):
"""File a bug on a product series.
Since it's not possible to file a bug on a product series directly,
the bug will first be filed on its product, then a series task will
be created.
"""
bug = bugtarget_filebug(productseries.product, summary, status=status)
getUtility(IBugTaskSet).createTask(
bug, getUtility(ILaunchBag).user, productseries, status=status)
return bug
def productSeriesSetUp(test):
"""Setup the `IProductSeries` test."""
setUp(test)
firefox = getUtility(IProductSet).getByName('firefox')
test.globs['bugtarget'] = firefox.getSeries('trunk')
test.globs['filebug'] = productseries_filebug
test.globs['question_target'] = firefox
def distributionSetUp(test):
"""Setup the `IDistribution` test."""
setUp(test)
test.globs['bugtarget'] = getUtility(IDistributionSet).getByName('ubuntu')
test.globs['filebug'] = bugtarget_filebug
test.globs['question_target'] = test.globs['bugtarget']
def distributionSourcePackageSetUp(test):
"""Setup the `IDistributionSourcePackage` test."""
setUp(test)
ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
test.globs['bugtarget'] = ubuntu.getSourcePackage('mozilla-firefox')
test.globs['filebug'] = bugtarget_filebug
test.globs['question_target'] = test.globs['bugtarget']
def distroseries_filebug(distroseries, summary, sourcepackagename=None,
status=None):
"""File a bug on a distroseries.
Since bugs can't be filed on distroseriess directly, a bug will
first be filed on its distribution, and then a series task will be
added.
"""
target = distroseries
if sourcepackagename:
target = target.getSourcePackage(sourcepackagename)
bug = bugtarget_filebug(distroseries.distribution, summary, status=status)
getUtility(IBugTaskSet).createTask(
bug, getUtility(ILaunchBag).user, target, status=status)
return bug
def distributionSeriesSetUp(test):
"""Setup the `IDistroSeries` test."""
setUp(test)
ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
test.globs['bugtarget'] = ubuntu.getSeries('hoary')
test.globs['filebug'] = distroseries_filebug
test.globs['question_target'] = ubuntu
def sourcepackage_filebug(source_package, summary, status=None):
"""File a bug on a source package in a distroseries."""
bug = distroseries_filebug(
source_package.distroseries, summary,
sourcepackagename=source_package.sourcepackagename, status=status)
return bug
def sourcepackage_filebug_for_question(source_package, summary, status=None):
"""Setup a bug with only one BugTask that can provide a QuestionTarget."""
bug = sourcepackage_filebug(source_package, summary, status=status)
# The distribution bugtask interferes with bugtarget-questiontarget.txt.
for bugtask in bug.bugtasks:
if IDistribution.providedBy(bugtask.target):
bugtask.transitionToStatus(
BugTaskStatus.INVALID, getUtility(ILaunchBag).user)
return bug
def sourcePackageSetUp(test):
"""Setup the `ISourcePackage` test."""
setUp(test)
ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
warty = ubuntu.getSeries('warty')
test.globs['bugtarget'] = warty.getSourcePackage('mozilla-firefox')
test.globs['filebug'] = sourcepackage_filebug
test.globs['question_target'] = ubuntu.getSourcePackage('mozilla-firefox')
class BugTargetQuestionTargetTestCase(TestCaseWithFactory):
"""Converting a bug into a question."""
layer = DatabaseFunctionalLayer
def test_canBeAQuestion_does_not_use_bugs(self):
bug = self.factory.makeBug()
pillar = bug.bugtasks[0].pillar
with person_logged_in(pillar.owner):
pillar.official_malone = False
pillar.official_answers = True
self.assertFalse(bug.canBeAQuestion())
def test_canBeAQuestion_does_not_use_answers(self):
bug = self.factory.makeBug()
pillar = bug.bugtasks[0].pillar
with person_logged_in(pillar.owner):
pillar.official_malone = True
pillar.official_answers = False
self.assertFalse(bug.canBeAQuestion())
def test_canBeAQuestion_uses_answers_and_bugs(self):
bug = self.factory.makeBug()
pillar = bug.bugtasks[0].pillar
with person_logged_in(pillar.owner):
pillar.official_malone = True
pillar.official_answers = True
self.assertTrue(bug.canBeAQuestion())
class TestBugTargetSearchTasks(TestCaseWithFactory):
"""Tests of IHasBugs.searchTasks()."""
layer = DatabaseFunctionalLayer
def setUp(self):
super(TestBugTargetSearchTasks, self).setUp()
self.bug = self.factory.makeBug()
self.target = self.bug.default_bugtask.target
self.milestone = self.factory.makeMilestone(product=self.target)
with person_logged_in(self.target.owner):
self.bug.default_bugtask.transitionToMilestone(
self.milestone, self.target.owner)
self.store = Store.of(self.bug)
self.store.flush()
self.store.invalidate()
def test_preload_other_objects(self):
# We can prejoin objects in calls of searchTasks().
# Without prejoining the table Milestone, accessing the
# BugTask property milestone requires an extra query.
with StormStatementRecorder() as recorder:
params = BugTaskSearchParams(user=None)
found_tasks = self.target.searchTasks(params)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(2)))
# When we prejoin Milestone, the milestone of our bugtask is
# already loaded during the main search query.
self.store.invalidate()
with StormStatementRecorder() as recorder:
params = BugTaskSearchParams(user=None)
prejoins = [(Milestone,
LeftJoin(Milestone,
BugTask.milestone == Milestone.id))]
found_tasks = self.target.searchTasks(params, prejoins=prejoins)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(1)))
def test_preload_other_objects_for_person_search_no_params_passed(self):
# We can prejoin objects in calls of Person.searchTasks().
owner = self.bug.owner
with StormStatementRecorder() as recorder:
found_tasks = owner.searchTasks(None, user=None)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(2)))
self.store.invalidate()
with StormStatementRecorder() as recorder:
prejoins = [(Milestone,
LeftJoin(Milestone,
BugTask.milestone == Milestone.id))]
found_tasks = owner.searchTasks(
None, user=None, prejoins=prejoins)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(1)))
def test_preload_other_objects_for_person_search_no_keywords_passed(self):
# We can prejoin objects in calls of Person.searchTasks().
owner = self.bug.owner
params = BugTaskSearchParams(user=None, owner=owner)
with StormStatementRecorder() as recorder:
found_tasks = owner.searchTasks(params)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(2)))
self.store.invalidate()
with StormStatementRecorder() as recorder:
prejoins = [(Milestone,
LeftJoin(Milestone,
BugTask.milestone == Milestone.id))]
found_tasks = owner.searchTasks(params, prejoins=prejoins)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(1)))
def test_preload_other_objects_for_person_search_keywords_passed(self):
# We can prejoin objects in calls of Person.searchTasks().
owner = self.bug.owner
params = BugTaskSearchParams(user=None, owner=owner)
with StormStatementRecorder() as recorder:
found_tasks = owner.searchTasks(params, order_by=BugTask.id)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(2)))
self.store.invalidate()
with StormStatementRecorder() as recorder:
prejoins = [(Milestone,
LeftJoin(Milestone,
BugTask.milestone == Milestone.id))]
found_tasks = owner.searchTasks(params, prejoins=prejoins)
found_tasks[0].milestone
self.assertThat(recorder, HasQueryCount(Equals(1)))
def test_suite():
"""Return the `IBugTarget` TestSuite."""
suite = unittest.TestSuite()
setUpMethods = [
productSetUp,
productSeriesSetUp,
distributionSetUp,
distributionSourcePackageSetUp,
distributionSeriesSetUp,
]
for setUpMethod in setUpMethods:
test = LayeredDocFileSuite('bugtarget-questiontarget.txt',
setUp=setUpMethod, tearDown=tearDown,
layer=DatabaseFunctionalLayer)
suite.addTest(test)
suite.addTest(unittest.TestLoader().loadTestsFromName(__name__))
return suite
|