1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
#!/bin/bash
#
# Runs xmlint, pyflakes and pylint on files changed from parent branch.
# Use '-v' to run pylint under stricter conditions with additional messages.
# Fail if any of the required tools are not installed.
if ! which pylint >/dev/null; then
echo "Error: pylint is not installed."
echo " Install the pylint package."
exit 1
elif ! which xmllint >/dev/null; then
echo "Error: xmlllint is not installed."
echo " Install the libxml2-utils package."
exit 1
elif ! which pyflakes >/dev/null; then
echo "Error: pyflakes is not installed."
echo " Install the pyflakes package."
exit 1
fi
function bzr {
# For pylint to operate properly, PYTHONPATH must point to the ./lib
# directory in the launchpad tree. This directory includes a bzrlib. When
# this script calls bzr, we want it to use the system bzrlib, not the one
# in the launchpad tree.
PYTHONPATH='' `which bzr` "$@"
}
rules="Using normal rules."
rcfile="--rcfile=utilities/lp.pylintrc"
if [ "$1" == "-v" ]; then
shift
rules="Using verbose rules."
rcfile="--rcfile=utilities/lp-verbose.pylintrc"
elif [ "$1" == "-vv" ]; then
shift
rules="Using very verbose rules."
rcfile="--rcfile=utilities/lp-very-verbose.pylintrc"
fi
if [ -z "$1" ]; then
# No command line argument provided, use the defaut logic.
bzr diff > /dev/null
diff_status=$?
if [ $diff_status -eq 0 ] ; then
# No uncommitted changes in the tree, lint changes relative to the
# parent.
rev=`bzr info | sed '/parent branch:/!d; s/ *parent branch: /ancestor:/'`
# XXX sinzui 2007-11-18 bug=163612:
# The bzr+ssh protocol causes an exception; fallback to sftp.
rev=`echo $rev | sed 's/bzr+ssh:/sftp:/'`
rev_option="-r $rev"
elif [ $diff_status -eq 1 ] ; then
# Uncommitted changes in the tree, lint those changes.
rev_option=""
else
# bzr diff failed
exit 1
fi
files=`bzr st --short $rev_option | sed '/^.[MN]/!d; s/.* //'`
else
# Add newlines so grep filters out pyfiles correctly later.
files=`echo $* | tr " " "\n"`
fi
echo "= Launchpad lint ="
echo ""
echo "Checking for conflicts. Running xmllint, pyflakes, and pylint."
echo "$rules"
if [ -z "$files" ]; then
echo "No changed files detected."
exit 0
else
echo
echo "Linting changed files:"
for file in $files; do
echo " $file"
done
fi
group_lines_by_file() {
# Format file:line:message output as lines grouped by file.
file_name=""
echo "$1" | sed 's,\(^[^ :<>=+]*:\),~~\1\n,' | while read line; do
current=`echo $line | sed '/^~~/!d; s/^~~\(.*\):$/\1/;'`
if [ -z "$current" ]; then
echo " $line"
elif [ "$file_name" != "$current" ]; then
file_name="$current"
echo ""
echo "$file_name"
fi
done
}
conflicts=""
for file in $files; do
# NB. Odd syntax on following line to stop lint.sh detecting conflict
# markers in itself.
if [ ! -f "$file" ]; then
continue
fi
if grep -q -e '<<<''<<<<' -e '>>>''>>>>' $file; then
conflicts="$conflicts $file"
fi
done
if [ "$conflicts" ]; then
echo ""
echo ""
echo "== Conflicts =="
echo ""
for conflict in $conflicts; do
echo "$conflict"
done
fi
xmlfiles=`echo "$files" | grep -E '(xml|zcml|pt)$'`
xmllint_notices=""
if [ ! -z "$xmlfiles" ]; then
xmllint_notices=`xmllint --noout $xmlfiles 2>&1 | sed -e '/Entity/,+2d'`
fi
if [ ! -z "$xmllint_notices" ]; then
echo ""
echo ""
echo "== XmlLint notices =="
group_lines_by_file "$xmllint_notices"
fi
pyfiles=`echo "$files" | grep '.py$'`
if [ -z "$pyfiles" ]; then
exit 0
fi
sed_deletes="/detect undefined names/d; /'_pythonpath' .* unused/d;"
pyflakes_notices=`pyflakes $pyfiles 2>&1 | sed "$sed_deletes"`
if [ ! -z "$pyflakes_notices" ]; then
echo ""
echo ""
echo "== Pyflakes notices =="
group_lines_by_file "$pyflakes_notices"
fi
export PYTHONPATH="/usr/share/pycentral/pylint/site-packages:lib:$PYTHONPATH"
pylint="python2.4 -Wi::DeprecationWarning `which pylint`"
# XXX sinzui 2007-10-18 bug=154140:
# Pylint should really do a better job of not reporting false positives.
sed_deletes="/^*/d; /Unused import \(action\|_python\)/d; "
sed_deletes="$sed_deletes /Unable to import .*sql\(object\|base\)/d; "
sed_deletes="$sed_deletes /_action.* Undefined variable/d; "
sed_deletes="$sed_deletes /_getByName.* Instance/d; "
sed_deletes="$sed_deletes /Redefining built-in .id/d; "
sed_deletes="$sed_deletes /Redefining built-in 'filter'/d; "
sed_deletes="$sed_deletes /<lambda>] Using variable .* before assignment/d; "
sed_deletes="$sed_deletes /Comma not followed by a space/{N;N};/,[])}]/d; "
sed_deletes="$sed_deletes /Undefined variable.*valida/d; "
sed_deletes="$sed_deletes s,^/.*lib/canonical/,lib/canonical,; "
# Note that you can disable specific tests by placing pylint
# instruction in a comment:
# # pylint: disable-msg=W0401,W0612,W0403
pylint_notices=`$pylint $rcfile $pyfiles | sed "$sed_deletes"`
if [ ! -z "$pylint_notices" ]; then
echo ""
echo ""
echo "== Pylint notices =="
group_lines_by_file "$pylint_notices"
fi
|