« back to all changes in this revision
Viewing changes to www/media/browser/listing.js
- Committer: wagrant
- Date: 2008-12-20 03:46:56 UTC
- Revision ID: svn-v3-trunk0:2b9c9e99-6f39-0410-b283-7f802c844ae2:trunk:1060
Make IVLE work fine in Firefox 3.1 (ie. Gecko/XULRunner 1.9.1). Gecko 1.9.1 has
a built-in JSON object, so our json2.js isn't used, and compatibility problems
arise. The only one significant to us is that Gecko's doesn't support having
a primitive as the root object. Unfortunately we use that sort of thing in a
few places, so IVLE ends up pretty much broken.
A few adjustments were needed both client- and server-side for proto changes:
- consoleservice and the JS interacting with it now deal with the key returned
by start_server in a dict like {'key': ...}.
- tutorialservice and interacting JS deal with code returned by getattempt in
a dict like {'code': ...}.
The JS repr() implementation used JSON.stringify on the given object, and was
used only with primitive objects in order to create function calls. This needed
to be eliminated for compatibility with the new Gecko, so these call
constructions were replaced with better events:
- listing.js constructed events for generated file listings by repr()ing some
strings. That is foul, so we instead use DOM operations from 'this' in a
somewhat nicer event handler.
- tutorial.js previously created save_exercise() call strings by repr()ing
lots of stuff. That was really bad, and broke like the rest. I replaced it
with something that's still bad, but not quite as awful - grabbing the call
string from the save button. This should be fixed at some point.
- console.js had some strange Firebug logging stuff which used repr(). I
removed it, as it shouldn't have been in released code in the first place.
repr() itself was removed after all references were.
a built-in JSON object, so our json2.js isn't used, and compatibility problems
arise. The only one significant to us is that Gecko's doesn't support having
a primitive as the root object. Unfortunately we use that sort of thing in a
few places, so IVLE ends up pretty much broken.
A few adjustments were needed both client- and server-side for proto changes:
- consoleservice and the JS interacting with it now deal with the key returned
by start_server in a dict like {'key': ...}.
- tutorialservice and interacting JS deal with code returned by getattempt in
a dict like {'code': ...}.
The JS repr() implementation used JSON.stringify on the given object, and was
used only with primitive objects in order to create function calls. This needed
to be eliminated for compatibility with the new Gecko, so these call
constructions were replaced with better events:
- listing.js constructed events for generated file listings by repr()ing some
strings. That is foul, so we instead use DOM operations from 'this' in a
somewhat nicer event handler.
- tutorial.js previously created save_exercise() call strings by repr()ing
lots of stuff. That was really bad, and broke like the rest. I replaced it
with something that's still bad, but not quite as awful - grabbing the call
string from the save button. This should be fixed at some point.
- console.js had some strange Firebug logging stuff which used repr(). I
removed it, as it shouldn't have been in released code in the first place.
repr() itself was removed after all references were.
added
removed
www/media/browser/listing.js
