← Back to branch summary

~drizzle-trunk/drizzle/development

« back to all changes in this revision

Viewing changes to drizzled/message/transaction.proto

Per Stew's suggestions in code review:

* Added assert()s in command_reader on field and value sizes
* Changed from string to bytes scalar types in transaction.proto definitions for Command
* Ensure writes in network byte order for the length of the written protos
* Fixed unclear cur_field vs. current_field in TransactionServices methods
* Remove delete calls for mem_root allocated Strings

Show diffs side-by-side

added added

removed removed

Lines of Context:
drizzled/message/transaction.proto
18
18
message InsertRecord
19
19
{
20
20
  repeated Table.Field insert_field = 3;
21
 
  repeated string insert_value = 4;
 
21
  repeated bytes insert_value = 4;
22
22
}
23
23
 
24
24
/*
27
27
message UpdateRecord
28
28
{
29
29
  repeated Table.Field update_field = 3;
30
 
  repeated string before_value = 4;
31
 
  repeated string after_value = 5;
 
30
  repeated bytes before_value = 4;
 
31
  repeated bytes after_value = 5;
32
32
  repeated Table.Field where_field = 6;
33
 
  repeated string where_value = 7;
 
33
  repeated bytes where_value = 7;
34
34
}
35
35
 
36
36
/*
39
39
message DeleteRecord
40
40
{
41
41
  repeated Table.Field where_field = 3;
42
 
  repeated string where_value = 4;
 
42
  repeated bytes where_value = 4;
43
43
}
44
44
 
45
45
/*