« back to all changes in this revision
Viewing changes to drizzled/function/time/unix_timestamp.cc
- Committer: Stewart Smith
- Date: 2009-06-30 06:09:40 UTC
- mto: (1079.3.8 bug360860-32bit-corruption)
- mto: This revision was merged to the branch mainline in revision 1089.
- Revision ID: stewart@flamingspork.com-20090630060940-lcqka7luen225f18
Replace MAX_(DATE|TIME).*_WIDTH defines in definitions.h with real (and correct) static const members to Temporal types.
This fixes the buffer overflow in https://bugs.launchpad.net/drizzle/+bug/373468
It also removes a handwritten snprintf in field/datetime.cc
However... this caused us to have to change Temporal to have a way to not
"convert" the int64_t value (so 20090101 becomes 20090101000000 etc) as it
has already been converted and we just want the Temporal type to do the
to_string conversion.
This still causes a failure in 'metadata' test due to size of timestamp type. I need feedback from Jay on when the usecond code comes into play to know the correct fix for this.
This fixes the buffer overflow in https://bugs.launchpad.net/drizzle/+bug/373468
It also removes a handwritten snprintf in field/datetime.cc
However... this caused us to have to change Temporal to have a way to not
"convert" the int64_t value (so 20090101 becomes 20090101000000 etc) as it
has already been converted and we just want the Temporal type to do the
to_string conversion.
This still causes a failure in 'metadata' test due to size of timestamp type. I need feedback from Jay on when the usecond code comes into play to know the correct fix for this.
- files modified:
- drizzled/create_field.cc
added
removed
drizzled/function/time/unix_timestamp.cc
