← Back to branch summary

~drizzle-trunk/drizzle/development

« back to all changes in this revision

Viewing changes to plugin/myisam/mi_open.cc

  • Committer: Stewart Smith
  • Date: 2009-07-02 06:42:18 UTC
  • mto: (1063.9.50 brian-tmp-fix)
  • mto: This revision was merged to the branch mainline in revision 1094.
  • Revision ID: stewart@flamingspork.com-20090702064218-1cjem3heufgd88ss
https://launchpad.net/bugs/387627
Fix BUG lp:387627: UPDATE can be TRUNCATE on TEMPORARY TABLE. Some special case code in MyISAM for 'if temporary table' was making (the included) test case fail. Root cause of what we've messed up in MyISAM was not found (after much investigation).

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugin/myisam/mi_open.cc
491
491
  {
492
492
    share->temporary=share->delay_key_write=1;
493
493
    share->write_flag=MYF(MY_NABP);
494
 
    share->w_locks++;                   /* We don't have to update status */
495
 
    share->tot_locks++;
 
494
    /*
 
495
     * The following two statements are commented out as a fix of
 
496
     * bug https://bugs.launchpad.net/drizzle/+bug/387627
 
497
     *
 
498
     * UPDATE can be TRUNCATE on TEMPORARY TABLE (MyISAM).
 
499
     * The root cause of why this makes a difference hasn't
 
500
     * been found, but this fixes things for now.
 
501
     */
 
502
//    share->w_locks++;                 // We don't have to update status
 
503
//    share->tot_locks++;
496
504
    info.lock_type=F_WRLCK;
497
505
  }
498
506
  if (((open_flags & HA_OPEN_DELAY_KEY_WRITE) ||