← Back to branch summary

~drizzle-trunk/drizzle/development

« back to all changes in this revision

Viewing changes to drizzled/sql_base.cc

  • Committer: Brian Aker
  • Date: 2010-10-28 09:15:33 UTC
  • mto: (1887.1.2 merge)
  • mto: This revision was merged to the branch mainline in revision 1888.
  • Revision ID: brian@tangent.org-20101028091533-7ryls520gk16c6fd
OSX found a reference to a function that was no longer declared.

Show diffs side-by-side

added added

removed removed

Lines of Context:
drizzled/sql_base.cc
217
217
          again. There they will wait until we update all tables version
218
218
          below.
219
219
 
220
 
          Setting some_tables_deleted is done by remove_table_from_cache()
 
220
          Setting some_tables_deleted is done by table::Cache::singleton().removeTable()
221
221
          in the other branch.
222
222
 
223
223
          In other words (reviewer suggestion): You need this setting of
678
678
  /*
679
679
    Note that we need to hold LOCK_open while changing the
680
680
    open_tables list. Another thread may work on it.
681
 
    (See: remove_table_from_cache(), mysql_wait_completed_table())
 
681
    (See: table::Cache::singleton().removeTable(), mysql_wait_completed_table())
682
682
    Closing a MERGE child before the parent would be fatal if the
683
683
    other thread tries to abort the MERGE lock in between.
684
684
  */
1513
1513
  /*
1514
1514
    Note that we need to hold LOCK_open while changing the
1515
1515
    open_tables list. Another thread may work on it.
1516
 
    (See: remove_table_from_cache(), mysql_wait_completed_table())
 
1516
    (See: table::Cache::singleton().removeTable(), mysql_wait_completed_table())
1517
1517
    Closing a MERGE child before the parent would be fatal if the
1518
1518
    other thread tries to abort the MERGE lock in between.
1519
1519
  */