← Back to branch summary

~drizzle-trunk/drizzle/development

« back to all changes in this revision

Viewing changes to drizzled/records.h

https://launchpad.net/bugs/588251
doStartTableScan() result not checked.

Add __attribute__((warn_unused_result)) to Cursor::startTableScan()
and by extension init_read_records

then go and fix the places where we weren't checking for errors.

This patch helped by Monty Widenius' patch to MariaDB. Greatly increased
confidence that we either handle the errors correctly or are at least
on par with bugs :)

Show diffs side-by-side

added added

removed removed

Lines of Context:
drizzled/records.h
181
181
    This is the most basic access method of a table using rnd_init,
182
182
    rnd_next and rnd_end. No indexes are used.
183
183
*/
184
 
  void init_read_record(Session *session, 
185
 
                        Table *reg_form,
186
 
                        optimizer::SqlSelect *select,
187
 
                        int use_record_cache, 
188
 
                        bool print_errors);
 
184
  int init_read_record(Session *session,
 
185
                       Table *reg_form,
 
186
                       optimizer::SqlSelect *select,
 
187
                       int use_record_cache,
 
188
                       bool print_errors) __attribute__ ((warn_unused_result));
189
189
 
190
190
  void end_read_record();
191
191