81
88
Where possible, SQL test cases should be created for your code. Our test cases
82
89
for bug fixes should be in the ``tests/suite/regression`` directory. For more
83
90
information about creating test cases please see the :ref:`test run <test-run-label>`
84
91
section of our documentation.
93
If writing a plugin, the other plugins in trunk have many examples of test cases.
95
You should attempt to test your code on multiple platforms before publishing
96
it or proposing it for merging. Your tests must pass on all
97
:ref:`supported_platforms` and be idempotent (pass when ran with
98
:option:`--repeat-test` 2). You can test on other platforms by using
99
`VirtualBox <https://www.virtualbox.org/>`_ or another virtualization
100
server, or by requesting access to the `Drizzle Jenkins server <http://jenkins.drizzle.org/>`_.
94
110
bzr push lp:~username/drizzle/trunk-bug-NNNNNN
96
112
This will create the branch on Launchpad which you will be able to see on the
97
`code page <https://code.launchpad.net/drizzle>`_. If you make some more commits you simply need to do just ``bzr push`` to get those revisions on Launchpad
113
`code page <https://code.launchpad.net/drizzle>`_. If you commit more changes
114
to your branch, just ``bzr push`` to publish the new changes.
103
Once your work is done and ready for review you can go to the
104
`code page <https://code.launchpad.net/drizzle>`_, and then click on your branch.
119
Once your work is done and ready for review, go to
120
`code page <https://code.launchpad.net/drizzle>`_, then click on your branch.
105
121
You will see a link labeled *Propose for merging*.
107
123
In this screen simply fill in what this branch does and click the
108
*Propose Merge* button. Someone will review the branch, usually within a day or
109
two. If approved, it will go though our rigourous testing process, which can
124
*Propose Merge* button. Members of the
125
`Drizzle merge team <https://launchpad.net/~drizzle-merge>`_
126
will review the branch, usually within a few days.
127
If approved, it will go though our rigourous testing process, which can
110
128
take several hours. If it needs more work, feedback will always be given to
added
removed
docs/contributing/code.rst
