~launchpad-pqm/launchpad/devel : changes

~launchpad-pqm/launchpad/devel » Changes from revision 4092.2.18

Rev	Summary	Authors	Date
4092.2.18	Respond to spiv's review: Respond to spiv's review: - Move the os.umask() test into the previously existing distroreleasequeue-debian-installer.txt file. This has the added advantage of removing the need for distroreleasequeue-debian-installer-bad-umask.txt and the special setup and teardown in test_system_documentation.py. Remove the d-d-i-b-u.txt file. - In customupload.py, fix the Python coding style nit and a typo in a comment. Fix the order of umask arguments to the CustomUploadBadUmask() exception call. - Restore the self.connector.disconnect() call in failWithTimeoutError() in distributionmirror_prober.py. The exception this causes is intermittent which probably means it's a timing or race bug. In any case, it doesn't cause the test suite to fail. - In test_on_merge.py, restore a Canonical coding style.	Barry Warsaw	17 years ago
4092.2.17	Based on comments from lifeless, add a test and some code so... Based on comments from lifeless, add a test and some code so that distroreleasequeue-debian-installer complains with a CustomUploadBadUmask error if the umask is not the expected 022 (as it is on production).	Barry Warsaw	17 years ago
4092.2.16	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.15	Revert some changes for tests that have been subsequently fi... Revert some changes for tests that have been subsequently fixed by other commits to rocketfuel. IOW, these changes are no longer necessary.	Barry Warsaw	17 years ago
4092.2.14	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.13	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.12	Thanks to jamesh, do a better job of draining the subprocess... Thanks to jamesh, do a better job of draining the subprocess's stdout and stderr after we kill it.	Barry Warsaw	17 years ago
4092.2.11	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.10	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.9	In the open_readers while loop, use a better Python idiom to... In the open_readers while loop, use a better Python idiom to test for empty rlist (i.e. "not rlist" is better than "len(rlist) == 0"). Also, remove a break after SIGKILLing a hung subprocess. This actually ends up losing buffered output, and it isn't necessary because once the process has been killed, the while loop will exit successfully due to proc.poll() not being None -- but /after/ the process's stdout has been printed.	Barry Warsaw	17 years ago
4092.2.8	ProberFactory.__init__(): Initialize self.connector to None ... ProberFactory.__init__(): Initialize self.connector to None in the constructor, and in failWithTimeoutError(), don't try to call self.connector.disconnect() unless that object is not None. Without this, you get a non-error causing exception in the test suite because self.connector is only set in startedConnecting(). If that doesn't get called, self has no .connector instance (without this change).	Barry Warsaw	17 years ago
4092.2.7	Repair initialise-from-parent.txt doctest in two ways. Firs... Repair initialise-from-parent.txt doctest in two ways. First, update the expected output to reflect current reality. Second, add a hack to fix an incompatibility between Python 2.4 and the python-apport package. The test requires that package, but that package (as of 0.76) uses Python 2.5's built-in any() function. Jam this into builtins for the test if it's not there, but add a big XXX comment so we can remove this when python-apport is fixed (as pitti is working on).	Barry Warsaw	17 years ago
4092.2.6	merge rocketfuel merge rocketfuel	Barry Warsaw	17 years ago
4092.2.5	Special-case the distroreleasequeue-debian-installer.txt doc... Special-case the distroreleasequeue-debian-installer.txt doctest so that the correct and expected umask (of 022) is set for the duration of this test. This is what the test expects and needs, and it is what the production environment will provide. Without this, the test's success is based on the whim of the local user's umask.	Barry Warsaw	17 years ago
4092.2.4	Fix test_ftparchive's testGenerateConfig() test. The comman... Fix test_ftparchive's testGenerateConfig() test. The command line apt-ftparchive now includes SHA1 and SHA256 hashes to go along with the MD5sum. The sample data needed to have these hash lines added. Did a minor bit of reformatting to fit into 79 columns.	Barry Warsaw	17 years ago
4092.2.3	typo typo	Barry Warsaw	17 years ago
4092.2.2	Update doctest for the different error output that PostgreSQ... Update doctest for the different error output that PostgreSQL 8.2 (which we now require) produces.	Barry Warsaw	17 years ago
4092.2.1	Update the doctest to reflect the slightly different error o... Update the doctest to reflect the slightly different error output that PostgreSQL 8.2 (which we now require) produces.	Barry Warsaw	17 years ago
4092	[r=Bjorn Tillenius] Fixes bug #49599. [r=Bjorn Tillenius] Fixes bug #49599.	Canonical.com Patch ...	17 years ago
4091	[trivial] Fixing #102545 (OOPS on SP/+packaging page). It fi... [trivial] Fixing #102545 (OOPS on SP/+packaging page). It fix template issues and add an effective pagetest for Packaging features.	Canonical.com Patch ...	17 years ago

Older »