~launchpad-pqm/launchpad/devel

Viewing all changes in revision 4092.2.18.

  • Committer: Barry Warsaw
  • Date: 2007-05-01 21:05:02 UTC
  • mto: This revision was merged to the branch mainline in revision 4191.
  • Revision ID: barry@canonical.com-20070501210502-ldycvjgdmm34s7os
Respond to spiv's review:

- Move the os.umask() test into the previously existing
  distroreleasequeue-debian-installer.txt file.  This has the added advantage
  of removing the need for distroreleasequeue-debian-installer-bad-umask.txt
  and the special setup and teardown in test_system_documentation.py.  Remove
  the d-d-i-b-u.txt file.

- In customupload.py, fix the Python coding style nit and a typo in a
  comment.  Fix the order of umask arguments to the CustomUploadBadUmask()
  exception call.

- Restore the self.connector.disconnect() call in failWithTimeoutError() in
  distributionmirror_prober.py.  The exception this causes is intermittent
  which probably means it's a timing or race bug.  In any case, it doesn't
  cause the test suite to fail.

- In test_on_merge.py, restore a Canonical coding style.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: