← Back to branch summary

~launchpad-pqm/launchpad/devel

« back to all changes in this revision

Viewing changes to lib/lp/app/browser/tests/test_linkchecker.py

  • Committer: Launchpad Patch Queue Manager
  • Date: 2011-09-16 08:56:39 UTC
  • mfrom: (13943.1.13 bug-title-849121)
  • Revision ID: launchpad@pqm.canonical.com-20110916085639-jrypx5sxptdzgtg6
[r=allenap, rvb][bug=849121] For bug links in Launchpad,
 add the bug's title to the title attribute of the URL if the bug is
 valid.

Show diffs side-by-side

added added

removed removed

Lines of Context:
lib/lp/app/browser/tests/test_linkchecker.py
24
24
 
25
25
    def check_invalid_links(self, result_json, link_type, invalid_links):
26
26
        link_dict = simplejson.loads(result_json)
27
 
        links_to_check = link_dict[link_type]
 
27
        links_to_check = link_dict[link_type]['invalid']
28
28
        self.assertEqual(len(invalid_links), len(links_to_check))
29
29
        self.assertEqual(set(invalid_links), set(links_to_check))
30
30
 
 
31
    def check_valid_links(self, result_json, link_type, valid_links):
 
32
        link_dict = simplejson.loads(result_json)
 
33
        links_to_check = link_dict[link_type]['valid']
 
34
        self.assertEqual(len(valid_links), len(links_to_check))
 
35
        self.assertEqual(set(valid_links), set(links_to_check))
 
36
 
31
37
    def make_valid_branch_links(self):
32
38
        branch = self.factory.makeProductBranch()
33
39
        valid_branch_url = self.BRANCH_URL_TEMPLATE % branch.unique_name
86
92
        link_checker = LinkCheckerAPI(object(), request)
87
93
        result_json = link_checker()
88
94
        self.check_invalid_links(
89
 
            result_json, 'invalid_branch_links', invalid_branch_urls)
 
95
            result_json, 'branch_links', invalid_branch_urls)
 
96
        self.check_invalid_links(
 
97
            result_json, 'bug_links', invalid_bug_urls)
 
98
        self.check_valid_links(
 
99
            result_json, 'bug_links', valid_bug_urls)
90
100
 
91
101
    def test_with_no_data(self):
92
102
        request = LaunchpadTestRequest()