← Back to branch summary

~launchpad-pqm/launchpad/devel

« back to all changes in this revision

Viewing changes to lib/lp/services/mail/incoming.py

  • Committer: Launchpad Patch Queue Manager
  • Date: 2011-10-25 10:00:32 UTC
  • mfrom: (14189.1.1 878140-dkim-nxdomain)
  • Revision ID: launchpad@pqm.canonical.com-20111025100032-dnqmu6l0o5ysetiq
[r=lifeless][bug=878140] NXDOMAIN during DKIM validation shouldn't
        record a warning/oops

Show diffs side-by-side

added added

removed removed

Lines of Context:
lib/lp/services/mail/incoming.py
139
139
    except dkim.DKIMException, e:
140
140
        log.warning('DKIM error: %r' % (e,))
141
141
        dkim_result = False
 
142
    except dns.resolver.NXDOMAIN, e:
 
143
        # This can easily happen just through bad input data, ie claiming to
 
144
        # be signed by a domain with no visible key of that name.  It's not an
 
145
        # operational error.
 
146
        log.info('DNS exception: %r' % (e,))
 
147
        dkim_result = False
142
148
    except dns.exception.DNSException, e:
143
149
        # many of them have lame messages, thus %r
144
150
        log.warning('DNS exception: %r' % (e,))